For MSVC 2015 only: also adding the C4127 suppression to test_eigen.cpp

rwgk · Oct 11, 2021 · 1b72808 · 1b72808
1 parent de09134
commit 1b72808
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/include/pybind11/eigen.h b/include/pybind11/eigen.h
@@ -24,7 +24,7 @@
 // it is probably best to keep this around indefinitely.
 #if defined(_MSC_VER)
 #  pragma warning(push)
-#  pragma warning(disable: 4127)
+#  pragma warning(disable: 4127) // C4127: conditional expression is constant
 #endif
 
 #include <Eigen/Core>

diff --git a/tests/test_eigen.cpp b/tests/test_eigen.cpp
@@ -13,6 +13,9 @@
 #include <pybind11/stl.h>
 
 #if defined(_MSC_VER)
+#if _MSC_VER < 1910  // VS 2015's MSVC
+#  pragma warning(disable: 4127) // C4127: conditional expression is constant
+#endif
 #  pragma warning(disable: 4996) // C4996: std::unary_negation is deprecated
 #endif