Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pretender version (^3.0.1) #70

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Conversation

givanse
Copy link
Contributor

@givanse givanse commented Feb 15, 2019

index.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@givanse
Copy link
Contributor Author

givanse commented Apr 12, 2019

pretender 3.0.1 is out 👍

@xg-wang
Copy link
Contributor

xg-wang commented Aug 23, 2019

Can we merge this PR?

@rwjblue
Copy link
Owner

rwjblue commented Nov 4, 2019

Seems fine, but I can't tell if I need to release as a major bump or not. The changelog in pretender is not terribly helpful (it says it dropped support for Node 6, yet this PR still passes on Node 6 CI).

@rwjblue rwjblue merged commit 29fb5ca into rwjblue:master Nov 4, 2019
@rwjblue rwjblue changed the title bump Pretender version Update Pretender version (^3.0.1) Nov 4, 2019
@givanse
Copy link
Contributor Author

givanse commented Nov 7, 2019

This addon is consuming the already built IIFE from Pretender. So it shouldn't matter what Node version Pretender supports. Should only be relevant if you are building Pretender yourself.

@givanse givanse deleted the bump-pretender branch November 7, 2019 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants