Skip to content

Commit

Permalink
Remove embertest from ESLint configuration.
Browse files Browse the repository at this point in the history
As of Ember 3.0 the new testing APIs introduced in emberjs/rfcs#232 and
emberjs/rfcs#268 are enabled and used by default. In these APIs no
globals are used, therefore this extra `tests/` override is removed.

This specifically removes the following globals from being allowed:

* `andThen`
* `click`
* `currentPath`
* `currentRouteName`
* `currentURL`
* `fillIn`
* `find`
* `findWithAssert`
* `keyEvent`
* `pauseTest`
* `resumeTest`
* `triggerEvent`
* `visit`
* `wait`
  • Loading branch information
rwjblue committed Jan 13, 2018
1 parent 30b1826 commit a4934bd
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 72 deletions.
9 changes: 0 additions & 9 deletions blueprints/app/files/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,6 @@ module.exports = {
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
// add your custom rules and overrides for node files here
})<% } %>
},

// test files
{
files: ['tests/**/*.js'],
excludedFiles: ['tests/dummy/**/*.js'],
env: {
embertest: true
}
}
]
};
9 changes: 0 additions & 9 deletions blueprints/module-unification-app/files/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,6 @@ module.exports = {
browser: false,
node: true
}
},

// test files
{
files: ['tests/**/*.js'],
excludedFiles: ['tests/dummy/**/*.js'],
env: {
embertest: true
}
}
]
};
9 changes: 0 additions & 9 deletions tests/fixtures/addon/npm/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,6 @@ module.exports = {
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
// add your custom rules and overrides for node files here
})
},

// test files
{
files: ['tests/**/*.js'],
excludedFiles: ['tests/dummy/**/*.js'],
env: {
embertest: true
}
}
]
};
9 changes: 0 additions & 9 deletions tests/fixtures/addon/yarn/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,6 @@ module.exports = {
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
// add your custom rules and overrides for node files here
})
},

// test files
{
files: ['tests/**/*.js'],
excludedFiles: ['tests/dummy/**/*.js'],
env: {
embertest: true
}
}
]
};
9 changes: 0 additions & 9 deletions tests/fixtures/app/npm/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,6 @@ module.exports = {
browser: false,
node: true
}
},

// test files
{
files: ['tests/**/*.js'],
excludedFiles: ['tests/dummy/**/*.js'],
env: {
embertest: true
}
}
]
};
9 changes: 0 additions & 9 deletions tests/fixtures/app/yarn/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,6 @@ module.exports = {
browser: false,
node: true
}
},

// test files
{
files: ['tests/**/*.js'],
excludedFiles: ['tests/dummy/**/*.js'],
env: {
embertest: true
}
}
]
};
9 changes: 0 additions & 9 deletions tests/fixtures/module-unification-app/npm/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,6 @@ module.exports = {
browser: false,
node: true
}
},

// test files
{
files: ['tests/**/*.js'],
excludedFiles: ['tests/dummy/**/*.js'],
env: {
embertest: true
}
}
]
};
9 changes: 0 additions & 9 deletions tests/fixtures/module-unification-app/yarn/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,6 @@ module.exports = {
browser: false,
node: true
}
},

// test files
{
files: ['tests/**/*.js'],
excludedFiles: ['tests/dummy/**/*.js'],
env: {
embertest: true
}
}
]
};

0 comments on commit a4934bd

Please sign in to comment.