Swap custom errors for Ember assertions

rwjblue · Mar 31, 2018 · a1af4df · a1af4df
1 parent 9b2838b
commit a1af4df
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 49 deletions.
diff --git a/addon/-private/errors.js b/addon/-private/errors.js
diff --git a/addon/components/step-manager.js b/addon/components/step-manager.js
@@ -1,9 +1,9 @@
 import Component from '@ember/component';
 import { set, get } from '@ember/object';
 import { isEmpty } from '@ember/utils';
+import { assert } from '@ember/debug';
 import hbs from 'htmlbars-inline-precompile';
 import StateMachine from 'ember-steps/-private/state-machine';
-import { MissingPropertyError } from 'ember-steps/-private/errors';
 
 const layout = hbs`
   {{yield (hash
@@ -57,16 +57,12 @@ export default Component.extend({
 
     // Set up the state machine
     const initialStep = get(this, 'currentStep');
-    if (!initialStep) {
-      throw new MissingPropertyError('currentStep');
-    }
+    assert('Missing `initialStep` property', !!initialStep);
 
     this._lastStep = initialStep;
 
     const stepCount = get(this, 'stepCount');
-    if (!stepCount) {
-      throw new MissingPropertyError('stepCount');
-    }
+    assert('Missing `stepCount` property', !!stepCount);
 
     set(
       this,

diff --git a/addon/components/step-manager/step.js b/addon/components/step-manager/step.js
@@ -1,9 +1,7 @@
 import Component from '@ember/component';
 import { computed, get, observer } from '@ember/object';
-import { isBlank } from '@ember/utils';
 import { assert } from '@ember/debug';
 import hbs from 'htmlbars-inline-precompile';
-import { StepNameError } from 'ember-steps/-private/errors';
 
 export default Component.extend({
   tagName: '',
@@ -19,12 +17,8 @@ export default Component.extend({
     this._super(...arguments);
 
     const name = get(this, 'name');
-    if (isBlank(name)) {
-      throw new StepNameError('Name must be provided');
-    }
-    if (typeof name !== 'string') {
-      throw new StepNameError('Name must be an immutable string');
-    }
+    assert('Step must have a name present', !!name);
+    assert('Step must be a `string`', typeof name === 'string');
 
     this['register-step'](this);
   },