Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct support for flattened/packed arrays #467

Merged
merged 7 commits into from
Mar 10, 2021
Merged

Conversation

albertz
Copy link
Member

@albertz albertz commented Mar 8, 2021

This partly implements #466.

@albertz
Copy link
Member Author

albertz commented Mar 8, 2021

These (and related) changes will probably get big. So maybe we should split this PR up?

So far this contains just the basic extensions for Data, as proposed. It's somewhat incomplete, but it's done in a way not to break existing code/configs. This is probably not so debatable anyway. So maybe we can merge this already, and then improve further with other separate PRs.

Edit: I think this PR is ready for review then, and a good base for the follow-up changes.

@albertz albertz force-pushed the albert-packed-arrays branch from dc4ed6a to 7020ce6 Compare March 8, 2021 23:58
@albertz albertz marked this pull request as ready for review March 9, 2021 00:00
@albertz
Copy link
Member Author

albertz commented Mar 9, 2021

(It's enough if at least one of you reviews. This will only be the base for future changes anyway.)

@albertz albertz force-pushed the albert-packed-arrays branch from 7020ce6 to 661f76d Compare March 9, 2021 15:23
@albertz
Copy link
Member Author

albertz commented Mar 9, 2021

As no-one has commented yet, and I already restructured some parts of BatchInfo, I directly pushed this to this PR.

@albertz albertz self-assigned this Mar 9, 2021
@albertz albertz force-pushed the albert-packed-arrays branch from 661f76d to b4d1212 Compare March 9, 2021 18:27
Copy link
Member

@Zettelkasten Zettelkasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good I think! I did not spot anything that seems off.

@albertz albertz merged commit 27b9d15 into master Mar 10, 2021
@albertz albertz deleted the albert-packed-arrays branch March 10, 2021 09:35
@albertz albertz mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants