Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job cleaner, use own thread pool for graph traversal #222

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

albertz
Copy link
Member

@albertz albertz commented Nov 27, 2024

@michelwi
Copy link
Contributor

how much speedup do you see here?

could there be instances where the Cleaner threadpool is already too busy and using the original threadpool would be beneficial?

@albertz
Copy link
Member Author

albertz commented Nov 27, 2024

how much speedup do you see here?

I cannot really measure this because the NFS behaves different every time. But I think it reduced it.

could there be instances where the Cleaner threadpool is already too busy and using the original threadpool would be beneficial?

I don't exactly understand. You don't want that the cleaner is blocking the main threadpool. That's exactly what is fixed here. Otherwise you block the main thread (e.g. update_jobs) (see discussion in #167). You never want to block the main thread. (At least I don't.)

@albertz albertz merged commit 442032d into master Nov 28, 2024
4 checks passed
@albertz albertz deleted the albert-cleaner-graph-own-thread-pool branch November 28, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants