Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tasklist structure #60

Merged
merged 11 commits into from
Aug 23, 2021
Merged

fix tasklist structure #60

merged 11 commits into from
Aug 23, 2021

Conversation

LarsNt
Copy link
Contributor

@LarsNt LarsNt commented Jul 16, 2021

This pull request fixes #59 .

Change Summary:

  • intasks are now link to parent chart
  • step and transition tasks of SSCs are automatically linked into intask
  • execution order of function blocks, steps, and transitions can now be changed by reordering intask task list
  • debug builds try to find an initial task before executing function blocks from C, providing warnings if unsuccessful

Breaking changes:

  • timing of vdivde3696 function blocks may change for saved databases
    • affected types: fio, aver, c, cs, deadt, dif, hn, integr, seo, tof1, ton1, tp1
  • loading saves on an old system causes doubled executions of function blocks

LarsNt added 11 commits June 8, 2021 22:28
@LarsNt
fb: link intask to parent chart task
e2b8dbf 
this makes the task structure transparent and
avoids executing from c code
@LarsNt
fb: fix setvar behaviour of any variables
140d520 
setterfunction of any variables was not executed when the value did not
change. this is contrary to other types.
@LarsNt
ssc: fix logic errors for rarely used features
0e99e48 
* unlink next step if it already has a task parent
* leaving the step when a transition activates
@LarsNt
ssc: fix tasklist structure for ssc
ce9aa4c 
* create links between steps / transitions and intask
* create links between step tasks and step
* veryfy connection to UrTask where execution from c code is necessary
@LarsNt
fb: limit is urtask search depth to avoid infinite loop
094d675
@LarsNt
ssc: correct exit tasklist linkage instead of verifying connection to…
d297440 
… urtask
@LarsNt
ssc: clean up code
524e168
@LarsNt
fb: rename tasklist check and return true on any inital task
6cf09e0
@LarsNt
ssc: disable tasklist check for non debug builds
563821f
@LarsNt
ssc: execute exit actions on transition trigger and ssc stop
2260648
@LarsNt
fb: make tasklist search depth dependent on MaxHierarchyDepth
89338cf
@mhthies mhthies mentioned this pull request Jul 29, 2021
Merged
@mhthies mhthies merged commit 5f1201a into ov3 Aug 23, 2021
mhthies added a commit that referenced this pull request Aug 23, 2021
@mhthies
Merge branch 'ov3' (PR #58) again, since #60 and #61 have been merged…
e34398c 
… into it
@mhthies mhthies mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LarsNt @mhthies