Fix relation/indexing processing Data object collision #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
processRelated and doIndex may be executed for the same operation object, doIndex mutates the Data of the operation which breaks the relation processing if it happens after the indexing which produces errors "Source field %s not found in document". The fix separates copies of Data between relation processing and indexing
c58
changed the title
c58
commented
May 26, 2024
| @@ -1336,7 +1336,29 @@ func (ic *indexClient) processRelated(root *gtm.Op) (err error) { | |||
| } | |||
| } | |||
| if visit { | |||
| q = append(q, rop) | |||
There was a problem hiding this comment.
rop is queued here for further relations processing, and also the same rop is added to the indexC here, so both may mutate the same Data
|
@rwynn first of all, thank you for the amazing tool! I hope you can find some time to check my PR. For now i switched my dockerfiles to pull monstache from my forked repo, so no rush on checking it, however I think the bug that I faced may affect some other people who have many Please let me know if you would like me to provide more context or somehow adjust the PR, I'm ready to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
processRelatedanddoIndexmay be executed for the same operation object,doIndexmutates theDataof the operation which breaks the relation processing if the relation processing happens after the indexing.The effect of such a collision may be observed as printed errors like "Source field _id not found in document: ...", because
doIndexremoves the_idfield from theDataobject as part of theprepareDataForIndexingfunction butextractDataattempts to read it in case if thesrc-field="_id"The fix separates copies of Data between relation processing and indexing, which eliminates the possibility of such a collision.