This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
updated deprecated code #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I went ahead and forked this project and added this PR (with the fix to pull gradle down) and it is available at https://github.com/emostar/audioplayer and published at https://pub.dartlang.org/packages/audioplayer2 |
|
Cool, thanks. There are many forks out there, I just need one to follow,
lol. I'm having an issue where it's not always notifying the os that the
file has played. Still diagnosing it. Also, I think development on this
current branch is abandoned.
…On Tue, Aug 28, 2018, 12:33 PM Emostar ***@***.***> wrote:
I went ahead and forked this project and added this PR (with the fix to
pull gradle down) and it is available at
https://github.com/emostar/audioplayer and published at
https://pub.dartlang.org/packages/audioplayer2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV-HfThGu9Pud2S-zmIt4vU0g5xVFYdgks5uVZsEgaJpZM4VPuiC>
.
|
|
Yeah, I'm trying to merge in the PRs to make the new repo be the definitive
repository, so there are less forks.
Which event(s) are you not receiving and on which OS?
…On Tue, Aug 28, 2018, 10:26 Jonathan White ***@***.***> wrote:
Cool, thanks. There are many forks out there, I just need one to follow,
lol. I'm having an issue where it's not always notifying the os that the
file has played. Still diagnosing it. Also, I think development on this
current branch is abandoned.
On Tue, Aug 28, 2018, 12:33 PM Emostar ***@***.***> wrote:
> I went ahead and forked this project and added this PR (with the fix to
> pull gradle down) and it is available at
> https://github.com/emostar/audioplayer and published at
> https://pub.dartlang.org/packages/audioplayer2
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#50 (comment)>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AV-HfThGu9Pud2S-zmIt4vU0g5xVFYdgks5uVZsEgaJpZM4VPuiC
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAL2r4CWr8gUgd7hbaI4ng6LA3tyrYm0ks5uVaePgaJpZM4VPuiC>
.
|
|
It wasnt changing the state to playing, so. My streambuilder widget wasn't
firing until the AudioPlayerState.STOPPED came through the stream, which
was the first event. This doesn't happen when running on Android.
…On Tue, Aug 28, 2018, 1:52 PM Emostar ***@***.***> wrote:
Yeah, I'm trying to merge in the PRs to make the new repo be the definitive
repository, so there are less forks.
Which event(s) are you not receiving and on which OS?
On Tue, Aug 28, 2018, 10:26 Jonathan White ***@***.***>
wrote:
> Cool, thanks. There are many forks out there, I just need one to follow,
> lol. I'm having an issue where it's not always notifying the os that the
> file has played. Still diagnosing it. Also, I think development on this
> current branch is abandoned.
>
> On Tue, Aug 28, 2018, 12:33 PM Emostar ***@***.***> wrote:
>
> > I went ahead and forked this project and added this PR (with the fix to
> > pull gradle down) and it is available at
> > https://github.com/emostar/audioplayer and published at
> > https://pub.dartlang.org/packages/audioplayer2
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <#50 (comment)
>,
> > or mute the thread
> > <
>
https://github.com/notifications/unsubscribe-auth/AV-HfThGu9Pud2S-zmIt4vU0g5xVFYdgks5uVZsEgaJpZM4VPuiC
> >
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#50 (comment)>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AAL2r4CWr8gUgd7hbaI4ng6LA3tyrYm0ks5uVaePgaJpZM4VPuiC
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV-HfbZ1DOfw2FhrBCT9tMSoyza-S_6Zks5uVa17gaJpZM4VPuiC>
.
|
|
Also, can you update the upper SDK constraints to 3.0? |
|
Can you file the bug report at https://github.com/emostar/audioplayer/issues, with a sample to reproduce it? I haven't looked into iOS yet with this, as I develop on Android. |
|
@emostar, you don't have an issues section on your fork? I need to submit one |
|
@ThinkDigitalRepair It's enabled now, not sure why it was off by default. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The program was using an outdated API method and that's been updated. Also, I deleted the widget test code that was throwing an error.