Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game crashes when calling custom function in watches #12

Closed
rxlecky opened this issue Apr 11, 2020 · 0 comments
Closed

Game crashes when calling custom function in watches #12

rxlecky opened this issue Apr 11, 2020 · 0 comments
Assignees
@rxlecky
Labels
crash

Comments

@rxlecky
Copy link
Owner

rxlecky commented Apr 11, 2020

This issue doesn't affect evaluator. Crash should not occur even if we decide not to support custom functions in watches
@rxlecky rxlecky added the crash label Apr 11, 2020
@rxlecky rxlecky self-assigned this Apr 11, 2020
rxlecky added a commit that referenced this issue Apr 11, 2020
@rxlecky
Fix crash when calling custom function in watches
d583c8b 
Replaced evaluete_watches mutex with atomic counter to prevent infinite
recursion that caused this crash. Also moved all locking from
_evaluate_watches to the inlined evaluate_watches, making _evaluate_watches
thread unsafe.

Fix #12
@rxlecky rxlecky closed this as completed Apr 11, 2020
rxlecky added a commit that referenced this issue Jan 29, 2021
@rxlecky
Fix crash when calling custom function in watches
d2dd228 
Replaced evaluete_watches mutex with atomic counter to prevent infinite
recursion that caused this crash. Also moved all locking from
_evaluate_watches to the inlined evaluate_watches, making _evaluate_watches
thread unsafe.

Fix #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rxlecky rxlecky

Labels
crash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rxlecky