Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use CPM to handle catch2 and codecoverage deps #26

Merged
merged 31 commits into from
Dec 15, 2023
Merged

Conversation

ryan597
Copy link
Owner

@ryan597 ryan597 commented Dec 14, 2023

CPM to handle dependencies

Before submitting
  • Was this discussed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@ryan597 ryan597 changed the title use CPM to handle catch2 and codecoverage deps [wip] use CPM to handle catch2 and codecoverage deps Dec 15, 2023
Copy link

Code Coverage Report

Coverage after merging cmake_cpm_deps into main will be
24.01%
Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines

@ryan597 ryan597 merged commit a263647 into main Dec 15, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant