Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow windows builds #31

Merged
merged 9 commits into from
Dec 16, 2023
Merged

allow windows builds #31

merged 9 commits into from
Dec 16, 2023

Conversation

ryan597
Copy link
Owner

@ryan597 ryan597 commented Dec 16, 2023

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

tests/CMakeLists.txt Outdated Show resolved Hide resolved
.github/workflows/build_and_test.yml Outdated Show resolved Hide resolved
Copy link

Code Coverage Report

Coverage after merging cmake_cpm_deps into main will be
74.00%
Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines

@ryan597 ryan597 enabled auto-merge (rebase) December 16, 2023 03:08
@ryan597 ryan597 disabled auto-merge December 16, 2023 03:10
@ryan597 ryan597 merged commit 6541448 into main Dec 16, 2023
6 checks passed
@ryan597 ryan597 deleted the cmake_cpm_deps branch December 16, 2023 03:11
@ryan597
Copy link
Owner Author

ryan597 commented Dec 16, 2023

Closes #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant