fix embed_json for multiline strings

ryanatkn · Jul 15, 2024 · dac5852 · dac5852
1 parent 014b508
commit dac5852
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/.changeset/slimy-tigers-lay.md b/.changeset/slimy-tigers-lay.md
@@ -0,0 +1,5 @@
+---
+'@ryanatkn/belt': patch
+---
+
+fix `embed_json` for multiline strings
diff --git a/src/lib/json.test.ts b/src/lib/json.test.ts
@@ -25,10 +25,11 @@ test('embed_json', () => {
 	assert.is(embed_json("hello'world"), `JSON.parse('"hello\\'world"')`);
 	assert.is(embed_json("'hello'w''or'''ld'"), `JSON.parse('"\\'hello\\'w\\'\\'or\\'\\'\\'ld\\'"')`);
 	assert.is(
-		embed_json(`hello
-world
-	newline`),
-		`JSON.parse('"hello\\\nworld\\\n\\tnewline"')`,
+		embed_json({a: 1, b: 2}, (d) => JSON.stringify(d, null, '\t')),
+		`JSON.parse('{\\
+	"a": 1,\\
+	"b": 2\\
+}')`,
 	);
 });
 

diff --git a/src/lib/json.ts b/src/lib/json.ts
@@ -41,4 +41,14 @@ export const canonicalize = <T extends Json>(value: T): T => {
  * Useful for optimizing JSON in JS because it parses faster.
  */
 export const embed_json = <T>(data: T, stringify: (data: T) => string = JSON.stringify): string =>
-	`JSON.parse('${stringify(data).replaceAll("'", "\\'").replaceAll('\\n', '\\\n')}')`;
+	`JSON.parse('${stringify(data).replaceAll("'", "\\'").replaceAll('\n', '\\\n')}')`;
+
+// 	const jsonString = stringify(data)
+// 		.replace(/\\/g, '\\\\')
+// 		.replace(/'/g, "\\'")
+// 		.replace(/\n/g, '\\n')
+// 		.replace(/\r/g, '\\r')
+// 		.replace(/\t/g, '\\t');
+
+// 	return `JSON.parse('${jsonString}')`;
+// };