check full task path to see if compilation is needed #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves a heuristic to detect if we want Gro to compile TypeScript when it tries to run a task. Previously it looked for the presence of the
build/directory, and now it looks for the actual target task file inbuild/. Typicallygro devtakes care of all of this for the developer, but this helps cover usage outside of that normal happy path.PR #11 changed
gro cleanto remove directories completely to accommodate the old heuristic, rather than simply emptying the directories like it did before. Although that's no longer needed, because it now looks for the specific task file, I think it's still good behavior to fully remove thebuild/anddist/directories. Feels cleaner for sure. 🧹🧹