Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dist build #156

Merged
merged 2 commits into from
Apr 7, 2021
Merged

fix dist build #156

merged 2 commits into from
Apr 7, 2021

Conversation

ryanatkn
Copy link
Owner

@ryanatkn ryanatkn commented Apr 7, 2021

We have broken metadata in our build since we switched over to esbuild, since we were using its output artifacts in dist/ instead of tsc. This should fix sourcemaps and typemaps, hopefully, by correctly prioritizing the TypeScript compiler's outputs over any . It's also cleaner and more correct - tsconfig.json points directly to dist/ and knows nothing about Gro's internal build system - that was bad behavior, broken design.

@ryanatkn ryanatkn merged commit 18d0787 into main Apr 7, 2021
@ryanatkn ryanatkn deleted the fix-build branch April 7, 2021 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant