Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build and deploy tasks to work with SvelteKit #157

Merged
merged 26 commits into from
Apr 7, 2021
Merged

Conversation

ryanatkn
Copy link
Owner

@ryanatkn ryanatkn commented Apr 7, 2021

SvelteKit fits nicely with the deployment process we've been doing. Gro was building production artifacts to dist/, SvelteKit outputs to build/.

The trick now is to do the best integration with what src/deploy.task.ts was doing for our static deployments to GitHub Pages.

  • basic behavior

So far this PR:

  • makes the build and deploy tasks work for SvelteKit projects
  • adds custom branch CLI arg to both tasks
  • adds the clean CLI arg to exit directly after cleaning up the git and Gro state
  • adds the helper hasSvelteKitFrontend and uses it to try to do the right thing
  • changes the deployment branch from gh-pages to deploy - we don't want to tie ourselves to GitHub, and now GitHub supports customizing the deployed branch name
  • uses SvelteKit's static/ to replace similar functionality we had for things like the CNAME file

@ryanatkn ryanatkn changed the title refactor deploy update static deploy to work with SvelteKit Apr 7, 2021
@ryanatkn ryanatkn marked this pull request as draft April 7, 2021 17:09
@ryanatkn ryanatkn changed the title update static deploy to work with SvelteKit update build and deploy tasks to work with SvelteKit Apr 7, 2021
@ryanatkn ryanatkn marked this pull request as ready for review April 7, 2021 19:55
@ryanatkn ryanatkn merged commit f774110 into main Apr 7, 2021
@ryanatkn ryanatkn deleted the refactor-deploy branch April 7, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant