-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update build and deploy tasks to work with SvelteKit #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanatkn
force-pushed
the
refactor-deploy
branch
from
April 7, 2021 18:07
a7417cc
to
9378f2e
Compare
ryanatkn
changed the title
update static deploy to work with SvelteKit
update build and deploy tasks to work with SvelteKit
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SvelteKit fits nicely with the deployment process we've been doing. Gro was building production artifacts to
dist/
, SvelteKit outputs tobuild/
.The trick now is to do the best integration with what
src/deploy.task.ts
was doing for our static deployments to GitHub Pages.So far this PR:
branch
CLI arg to both tasksclean
CLI arg to exit directly after cleaning up the git and Gro statehasSvelteKitFrontend
and uses it to try to do the right thinggh-pages
todeploy
- we don't want to tie ourselves to GitHub, and now GitHub supports customizing the deployed branch namestatic/
to replace similar functionality we had for things like theCNAME
file