add config build and fix clean #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanatkn
force-pushed
the
fix-clean
branch
4 times, most recently
from
007f6ed
to
fabc2d9
Compare
ryanatkn
force-pushed
the
main
branch
4 times, most recently
from
710351b
to
01d321c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought I had a fix in #203, turns out I was just hitting happy code paths.
This issue is a little scary in how deep seated it is, and the possible outcomes include publishing stale files to npm. Unacceptable!
Gro's build and task system are interlinked, which has great API and UX payoffs, but the internal system is complex, and further, it's more complicated than needed for reasons that are no longer relevant.
I think the correct fix involves rethinking the Gro system build, which is currently the one named
"node". Things have changed significantly since I designed the original system thanks to the speed ofesbuild-- I knew I was hacking around a simple, correct system to get acceptable performance, and now we can remove those hacks without impacting UX too much, I think/hope.