Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prebundle externals only in development #249

Merged
merged 2 commits into from
Jul 12, 2021
Merged

prebundle externals only in development #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b8ec9c
prebundle only for development builds
ryanatkn Jul 12, 2021
4b2ce47
prebundle only in development
ryanatkn Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## 0.33.1

- fix `gro_adapter_gro_frontend` by prebundling externals only in development
([#249](https://github.com/feltcoop/gro/pull/249))
- upgrade `es-module-lexer@0.7.1`
([#248](https://github.com/feltcoop/gro/pull/248))

Expand Down
10 changes: 5 additions & 5 deletions src/build/postprocess.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,9 @@ const to_build_dependency = (
ctx: Build_Context,
): Build_Dependency => {
const {dev, externals_aliases, build_dir} = ctx;
const browser = build_config.platform === 'browser';
let build_id: string;
let final_specifier = specifier; // this is the raw specifier, but pre-mapped for common externals
const prebundle = dev && build_config.platform === 'browser'; // don't prebundle in production
const is_external_import = is_external_module(specifier);
const is_external_imported_by_external = source.id === EXTERNALS_SOURCE_ID;
const is_external = is_external_import || is_external_imported_by_external;
Expand All @@ -180,7 +180,7 @@ const to_build_dependency = (
mapped_specifier = to_build_extension(specifier, dev);
if (is_external_import) {
// handle regular externals
if (browser) {
if (prebundle) {
if (mapped_specifier in externals_aliases) {
mapped_specifier = externals_aliases[mapped_specifier];
}
Expand All @@ -201,12 +201,12 @@ const to_build_dependency = (
}
} else {
// handle common externals, imports internal to the externals
if (browser) {
if (prebundle) {
build_id = join(dir, specifier);
// use absolute paths for internal externals specifiers, so we get stable ids
final_specifier = build_id;
} else {
// externals imported in Node builds use Node module resolution
// externals imported in production and Node builds use Node module resolution
build_id = mapped_specifier;
}
}
Expand All @@ -224,7 +224,7 @@ const to_build_dependency = (
mapped_specifier,
original_specifier: specifier,
build_id,
external: browser && is_external,
external: prebundle && is_external,
};
};

Expand Down