support js #270
Merged
support js #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanatkn
force-pushed
the
support-js
branch
from
79928a7
to
d3496ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gro was designed for TypeScript projects from the start, and I never had a usecase for
.jsfiles. Until now -- we now have a.jsfile for sharing constants betweensvelte.config.jsand regular code in felt-server. And it seems super silly to not have.jsfile import support. So this PR adds that.As mentioned in the added comments, this is a flawed implementation because Gro wants to resolve build ids to source files up front, and it has no way to self-correct for changes. (e.g. changing from a
.tsfile to a.jsfile while watching) It's probably about time to move to a Rollup-compatible plugin system for e.g. resolving import specifiers, but that will require some deeper changes to how Gro works.