do not include api server plugin for production builds

changelog.md

@@ -1,5 +1,10 @@
 # changelog
 
+## 0.44.1
+
+- change default config to not run the api server during build
+  ([#275](https://github.com/feltcoop/gro/pull/275))
+
 ## 0.44.0
 
 - **break**: upgrade `@feltcoop/felt@0.13.0` and make it a peer dependency

src/adapt/groAdapterSveltekitFrontend.ts

@@ -10,13 +10,15 @@ export interface Options {
 	dir: string;
 	sveltekitDir: string;
 	hostTarget: HostTarget;
+	deploymentMode: 'server' | 'middleware' | 'both'; // TODO hacky option that works around `@sveltejs/adapter-node`'s lack of configurable outputs
 }
 
 // TODO this hacks around the fact that we don't create a proper Gro build for SvelteKit frontends
 export const createAdapter = ({
 	dir = `${DIST_DIRNAME}/${SVELTEKIT_DIST_DIRNAME}`,
 	sveltekitDir = SVELTEKIT_BUILD_DIRNAME,
 	hostTarget = 'githubPages',
+	deploymentMode = 'middleware',
 }: Partial<Options> = EMPTY_OBJECT): Adapter => {
 	dir = stripTrailingSlash(dir);
 	return {
@@ -26,8 +28,19 @@ export const createAdapter = ({
 
 			await fs.copy(sveltekitDir, dir);
 
-			if (hostTarget === 'githubPages') {
-				await ensureNojekyll(fs, dir);
+			switch (hostTarget) {
+				case 'githubPages': {
+					await ensureNojekyll(fs, dir);
+					break;
+				}
+				case 'node': {
+					if (deploymentMode === 'middleware') {
+						await fs.remove(`${dir}/index.js`);
+					} else if (deploymentMode === 'server') {
+						await fs.remove(`${dir}/middlewares.js`);
+					}
+					break;
+				}
 			}
 		},
 	};

src/adapt/utils.ts

@@ -64,7 +64,7 @@ export const copyDist = async (
 	);
 };
 
-export type HostTarget = 'githubPages' | 'static';
+export type HostTarget = 'githubPages' | 'static' | 'node';
 
 const NOJEKYLL_FILENAME = '.nojekyll';
 

src/config/gro.config.default.ts

@@ -48,7 +48,12 @@ export const config: GroConfigCreator = async ({fs, dev}) => {
 		types: enableNodeLibrary,
 		plugin: async () => [
 			enableDevServer ? (await import('../plugin/groPluginDevServer.js')).createPlugin() : null,
-			enableApiServer ? (await import('../plugin/groPluginApiServer.js')).createPlugin() : null,
+			// TODO some usecases may need to run the API server during the build for e.g. prerendering,
+			// but it's currently disabled because the adapter-node usecase has the production API server
+			// depend on the middleware created later in the adapt step of the build
+			enableApiServer && dev
+				? (await import('../plugin/groPluginApiServer.js')).createPlugin()
+				: null,
 			enableSveltekitFrontend
 				? (await import('../plugin/groPluginSveltekitFrontend.js')).createPlugin()
 				: null,
@@ -66,7 +71,9 @@ export const config: GroConfigCreator = async ({fs, dev}) => {
 				? (await import('../adapt/groAdapterGroFrontend.js')).createAdapter()
 				: null,
 			enableSveltekitFrontend
-				? (await import('../adapt/groAdapterSveltekitFrontend.js')).createAdapter()
+				? (await import('../adapt/groAdapterSveltekitFrontend.js')).createAdapter({
+						hostTarget: enableApiServer ? 'node' : 'githubPages',
+				  })
 				: null,
 		],
 	};