Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix env #284

Merged
merged 18 commits into from
Dec 10, 2021
Merged

fix env #284

merged 18 commits into from
Dec 10, 2021

Conversation

ryanatkn
Copy link
Owner

@ryanatkn ryanatkn commented Nov 18, 2021 •
edited
Loading

Fixes env handling, hopefully. Spawns tasks as new processes if they are production and the current NODE_ENV is dev.

Future:

  • Vite uses import.meta.env, but Gro supports only process.env.NODE_ENV. We'll standardize on Vite's version

@ryanatkn ryanatkn force-pushed the fix-env branch 2 times, most recently from 9c1e463 to f293bcc Compare December 1, 2021 07:58
ryanatkn
ryanatkn commented Dec 1, 2021
View reviewed changes
src/task/invokeTask.ts Outdated Show resolved Hide resolved
ryanatkn
ryanatkn commented Dec 2, 2021
View reviewed changes
src/deploy.task.ts Outdated Show resolved Hide resolved
@ryanatkn ryanatkn marked this pull request as ready for review December 10, 2021 02:08
@ryanatkn ryanatkn merged commit ab209ec into main Dec 10, 2021
@ryanatkn ryanatkn deleted the fix-env branch December 10, 2021 02:14
@ryanatkn ryanatkn mentioned this pull request Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ryanatkn