Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change .well-known/package.json to use the static directory #428

Merged
merged 21 commits into from
Nov 9, 2023

Conversation

ryanatkn
Copy link
Owner

@ryanatkn ryanatkn commented Oct 23, 2023

If you link to the .well-known/package.json, SvelteKit won't see it during the build. I think the build is fine, it just fixes the error.

I knew this was the better implementation but I was being lazy, it's more work and I want to make reusable helpers for creating the file temporarily and then cleaning up.

like

const cleanup = copy_temporarily(...)

(similar usecase with "public": true and src/)

  • try/catch around build to ensure cleanup

@ryanatkn ryanatkn marked this pull request as ready for review November 8, 2023 23:43
@ryanatkn ryanatkn merged commit 2b8d89e into main Nov 9, 2023
1 check passed
@ryanatkn ryanatkn deleted the copy-to-static branch November 9, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant