Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor filer types #55

Merged
merged 3 commits into from
Sep 26, 2020
Merged

refactor filer types #55

merged 3 commits into from
Sep 26, 2020

Conversation

ryanatkn
Copy link
Owner

@ryanatkn ryanatkn commented Sep 26, 2020

This renames some of the Filer and Compiler types. It also changes the Filer's compiled file type to wrap compilations instead of extending them. This provides a cleaner separation between the compiler's return value and all of the subsequent metadata that we add (there will be more in the future), at the cost of some duplication of properties.

This is in preparation for the postprocess step which makes the compiled file's contents potentially diverge from the original compilation's, and by storing the original reference, we retain the un-postprocessed version. We need to postprocess files to update their module paths to support Svelte and other usecases. I currently like the idea of isolating the Compiler to not touch module paths, just like the TypeScript and Svelte compilers.

@ryanatkn ryanatkn merged commit 68bca52 into master Sep 26, 2020
@ryanatkn ryanatkn deleted the refactor-filer-types branch September 26, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant