-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache compilations to speed up startup #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces more sophisticated caching to avoid unnecessary work on startup. Previously, the
Filer
re-compiled everything on startup and then compared results to what was on disk, which is usually wasted work. TheFiler
now stores a JSON metadata file corresponding to each source file (including externals) with the minimum amount of information needed to rehydrate compilations on startup. Right now, this metadata includes 1) a hash of the source contents, 2) a list of the compiled files' paths, which correspond to built files on disk, and 3) their encoding, likeutf8
ornull
.By combining the metadata with the built files on disk, we can avoid re-compiling files on startup. This cut the
gro dev
startup time in half for Gro itself, and for frontend projects that use a lot of Svelte, this could improve startup time by orders of magnitude, depending on the size of the project.There remain corner cases that require the developer to manually clear the cache, like updating dependencies or changing compilation options that aren't handled by the
Filer
. We can mitigate some of these problems down the road - for now, if something looks off,gro clean
should be the go-to fix.