Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeGuleSider.dk / GuleSider.no / Krak.dk - Broken search results / maps (Fanboy's Annoyance List / Fanboy's Cookie List) #1261

Closed
THEtomaso opened this issue Dec 10, 2019 · 19 comments

Comments

@THEtomaso
Copy link

THEtomaso commented Dec 10, 2019

Affected sites:

https://www.degulesider.dk/
https://www.gulesider.no/
https://www.krak.dk/

Issue:

Search results / maps are blocked.

Examples:

https://kort.degulesider.dk/
https://kart.gulesider.no/
https://map.krak.dk/

Screenshot:

Not needed, as the problem is obvious.

Problem filters:

  • Fanboy's Annoyance List
  • Fanboy's Cookie List

Problem rule:

||cookieinformation.com^$third-party

Possible fix:

- @@||policy.app.cookieinformation.com^$script,domain=eniro.se
+ @@||policy.app.cookieinformation.com^$script,domain=degulesider.dk|eniro.se|gulesider.no|krak.dk

+ ||cookieinformation.com/cookiesharingiframe$important
(Needed to block the cookie popups)

Other problem filters:

--

System info:

  • OS/version: Windows 8.1 Pro (x64)
  • Browser/version: Pale Moon v28.8.0 (x64)
  • Adblock Extension/version: uBlock Origin v1.16.4.11 (XUL)
@THEtomaso
Copy link
Author

@DandelionSprout

@DandelionSprout
Copy link
Contributor

As the problem spans 2 lists, and I am unable to figure out what IDCAC's extension-version-exclusive problem rule is in a hurry, I wouldn't be able to certify or properly write any whitelisting entries to cover both lists. So I'll hold out on adding anything to my list as it currently stands.

@THEtomaso
Copy link
Author

THEtomaso commented Dec 10, 2019

IDCAC's filter list problem rule is this one:
policy.app.cookieinformation.com$domain=~kartor.eniro.se
How is its potential "extension-version-exclusive" rule relevant, anyway?
Are whitelistings in uBO, or any other blocker for that matter, actually able to affect the extension version?

@DandelionSprout
Copy link
Contributor

Ah, wait, no, I saw wrong previously. I somehow managed to mistake policy.app.cookieinformation.com$domain=~kartor.eniro.se for being a whitelist rule à la @@||.

I'm currently doing some late-night Ring Fit Adventure, but I'll add @@||cookieinformation.com^$third-party,domain=gulesider.no after I'm finished with it, plus I'll look into if Eniro have any other map domains as well.

@THEtomaso
Copy link
Author

THEtomaso commented Dec 10, 2019

OK. 👍
Good luck with that weird Ring Fit thing! (yes, I searched it up :) )

Currently playing this myself:
https://www.youtube.com/watch?v=ncC9jrCqgG8

@DandelionSprout
Copy link
Contributor

After having finished tonight's exercise, these four were the Eniro map sites I could find, and for which I propose that all three involved lists expand their whitelistings:

@@||cookieinformation.com^$third-party,domain=kart.gulesider.no|map.krak.dk|kort.degulesider.dk|kartor.eniro.se

DandelionSprout added a commit to DandelionSprout/adfilt that referenced this issue Dec 10, 2019
@THEtomaso THEtomaso changed the title GuleSider.no - Broken search results / maps (Fanboy's Annoyance List / Fanboy's Cookie List) DeGuleSider.dk / GuleSider.no / Krak.dk - Broken search results / maps (Fanboy's Annoyance List / Fanboy's Cookie List) Dec 11, 2019
@THEtomaso
Copy link
Author

First post updated

@THEtomaso
Copy link
Author

THEtomaso commented Dec 11, 2019

@DandelionSprout / @lassekongo83:
When whitelisting policy.app.cookieinformation.com, an extra rule is needed to block the cookie popups (see first post).

ryanbr added a commit to easylist/easylist that referenced this issue Dec 11, 2019
@ryanbr
Copy link
Owner

ryanbr commented Dec 11, 2019

Does this help?

lassekongo83 added a commit to lassekongo83/Frellwits-filter-lists that referenced this issue Dec 11, 2019
@THEtomaso
Copy link
Author

Yes, that works too, and does indeed appear to be the simplest solution! :)

@THEtomaso
Copy link
Author

THEtomaso commented Dec 12, 2019

@DandelionSprout:
At all of the mentioned sites (kort.degulesider.dk / kart.gulesider.no / map.krak.dk), there's an empty ad container, right below the search box (in the top left corner).
Possible fix: degulesider.dk,gulesider.no,krak.dk##.e-banner

--

EDIT:
Fanboy's Annoyance List / Fanboy's Cookie List and Frellwit's Swedish Filter already has that very same rule in place, but only covering eniro.se (eniro.se##.e-banner).

DandelionSprout added a commit to DandelionSprout/adfilt that referenced this issue Dec 12, 2019
@THEtomaso
Copy link
Author

THEtomaso commented Feb 13, 2020

The sites are broken again.

Affected sites:

https://www.degulesider.dk/
https://www.gulesider.no/
https://www.krak.dk/

Issue:

Search results / maps are blocked.

Examples:

https://kort.degulesider.dk/
https://kart.gulesider.no/
https://map.krak.dk/

Problem filters:

  • EasyList Cookie List (a.k.a. Fanboy's Cookie List)
  • Fanboy's Annoyance List

Problem rule:

||cookieinformation.com/*/*.js

Possible fix:

- @@||policy.app.cookieinformation.com^$script,domain=eniro.se
+ @@||policy.app.cookieinformation.com^$script,domain=degulesider.dk|eniro.se|gulesider.no|krak.dk

Temporary fix:

@@||cookieinformation.com/*/*.js$domain=degulesider.dk|gulesider.no|krak.dk

Note:

Blocked scripts will vary, depending on your regional location/settings (da.js = danish / en.js = english / nb.js = norwegian,bokmål, etc..).

Other problem filters:

* AdGuard Annoyances filter: ###CookieConsent (@BlazDT)
* I don't care about cookies: ###CookieConsent (@kiboke)

--

@DandelionSprout

@THEtomaso
Copy link
Author

Sorry, I seem to have made a mistake when first testing this..
###CookieConsent doesn't break the pages, only ||cookieinformation.com/*/*.js does!
Previous post edited

DandelionSprout added a commit to DandelionSprout/adfilt that referenced this issue Feb 13, 2020
@spirillen
Copy link

hmmm weird as I have blocked cookieinformation.com entirely from my network, and I have no issues on either of those pages...

But just a thought
Why isn't cookieinformation.com blocked as ||cookieinformation.com^ ?

Personally I had no breakage by blocking that entirely....

@THEtomaso
Copy link
Author

THEtomaso commented Feb 13, 2020

It's a GDPR issue.
Those type of issues are often highly region-dependent!

BTW; you did test the EXAMPLE links, right, and not the ones under "Affected sites"?

@spirillen
Copy link

You are actually right... If you try to access the maps directly there comes a problem, but when it is a integrated part of a search it's working

`https://www.krak.dk/hansen/firmaer`

image

`https://map.krak.dk/`

image

PS: all three example url are owned by eniro.se 😈

`https://kartor.eniro.se/s/J%C3%B6nsson`

image

@THEtomaso
Copy link
Author

THEtomaso commented Feb 13, 2020

when it is a integrated part of a search it's working

That's certainly not the case for all of the affected sites, because I noticed this problem today, when using the search function at gulesider.no.

BTW; I've edited the report, suggesting a different solution (the same as in my original post), since EasyList Cookie List already contains a fix for eniro.se:
#1261 (comment)

@spirillen
Copy link

@THEtomaso have you tried blocking cookieinformation.com on DNS/hosts level and tried again? mostly because I'm curious of what is/would happen....

@THEtomaso
Copy link
Author

I'll take your word for it, and assume that it will have a different effect! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants