Add table name to validation errors. #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you like this ported to https://github.com/clarkie/dynogels |
|
@clarkie sure. what's been added to this over vogels? |
|
Not a lot as yet but I'm working on it. I've updated joi bit still need to go to v9. |
|
Merged into dynogels. But now I'm confused as to what version to bump: http://stackoverflow.com/questions/38432774/semver-on-nested-object-in-javascript-major-minor-or-patch |
|
Released as part of Dynogels v5.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validation (joi) errors occur there is no context to help determine what table the error occurred on. This small pull request fixes this. The more robust approach would be to extend Error and add table as a property and then modify the toString function, but that may be more than is needed.