Account for playback speed in current position #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'd been meaning to get around to this! |
iamgoddog
added a commit
to iamgoddog/audio_service
that referenced
this pull request
Apr 13, 2020
* master: Version 0.6.2 Fix onAddQueueItemAt invokeMethod in AudioServicePlugin.java (ryanheise#192) Fix bug with FlutterIsolate (ryanheise#188) Account for playback speed in current position (ryanheise#184) Fix background seek on iOS. (ryanheise#172) Version 6.0.1 Handle focus request failure more gracefully # Conflicts: # android/src/main/java/com/ryanheise/audioservice/AudioServicePlugin.java # ios/Classes/AudioServicePlugin.m # lib/audio_service.dart
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the currentPosition getter doesn't account for playback at different speeds. This change should address that. Basically just multiplies the elapsed time by the playback speed and then calls
toInt().