Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a normal constructor instead of a factory method to create an unrated Rating object #34

Merged
merged 1 commit into from
Feb 2, 2019
Merged

Use a normal constructor instead of a factory method to create an unrated Rating object #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/audio_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,7 @@ class Rating {
Rating.newThumbRating(bool isThumbsUp) : this._internal(RatingStyle.thumbUpDown, isThumbsUp);

/// Create a new unrated rating.
factory Rating.newUnratedRating(RatingStyle ratingStyle) {
return Rating._internal(ratingStyle, null);
}
Rating.newUnratedRating(RatingStyle ratingStyle) : this._internal(ratingStyle, null);

/// Return the rating style.
RatingStyle getRatingStyle() => _type;
Expand Down