Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ended isolate + unit tests for it #735

Closed
wants to merge 18 commits into from
Closed

Ended isolate + unit tests for it #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6e6eaee
added isolate unit tests
nt4f04uNd Jun 14, 2021
5da34d1
fix docs, add throw tests
nt4f04uNd Jun 14, 2021
cd5d8ea
doc
nt4f04uNd Jun 14, 2021
874a5de
added rating test
nt4f04uNd Jun 14, 2021
614ea98
rename mock base audio handler file
nt4f04uNd Jun 14, 2021
64c7bd4
+
nt4f04uNd Jun 14, 2021
39917e2
More tests
nt4f04uNd Jun 15, 2021
50b53c1
Better test isolation
nt4f04uNd Jun 15, 2021
c46dd8c
Merge remote-tracking branch 'upstream/one-isolate' into isolates
nt4f04uNd Jun 20, 2021
04c9f14
apply optional parameters
nt4f04uNd Jun 20, 2021
807811b
grammar
nt4f04uNd Jul 4, 2021
9fe4294
make IsolateAudioHandler private
nt4f04uNd Jul 4, 2021
e0a11f7
fix wrong comment
nt4f04uNd Jul 4, 2021
5125edc
marked hostHandler as only for testing
nt4f04uNd Jul 5, 2021
ecf7391
web error message
nt4f04uNd Jul 5, 2021
141b309
remove unnecessary condition
nt4f04uNd Jul 5, 2021
72faf76
Merge branch 'one-isolate' into isolates
nt4f04uNd Jul 6, 2021
a06a115
+
nt4f04uNd Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions audio_service/example/lib/example_multiple_handlers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ class MainScreen extends StatelessWidget {
/// A stream reporting the combined state of the current queue and the current
/// media item within that queue.
Stream<QueueState> get _queueStateStream =>
Rx.combineLatest2<List<MediaItem>?, MediaItem?, QueueState>(
Rx.combineLatest2<List<MediaItem>, MediaItem?, QueueState>(
_audioHandler.queue,
_audioHandler.mediaItem,
(queue, mediaItem) => QueueState(queue, mediaItem));
Expand All @@ -235,7 +235,7 @@ class MainScreen extends StatelessWidget {
}

class QueueState {
final List<MediaItem>? queue;
final List<MediaItem> queue;
final MediaItem? mediaItem;

QueueState(this.queue, this.mediaItem);
Expand Down Expand Up @@ -286,7 +286,6 @@ class MainSwitchHandler extends SwitchAudioHandler {
/// An [AudioHandler] for playing a list of podcast episodes.
class AudioPlayerHandler extends BaseAudioHandler
with QueueHandler, SeekHandler {
// ignore: close_sinks
final BehaviorSubject<List<MediaItem>> _recentSubject =
BehaviorSubject.seeded(<MediaItem>[]);
final _mediaLibrary = MediaLibrary();
Expand Down
Loading