-
Notifications
You must be signed in to change notification settings - Fork 1
Issues: ryankeefe92/Episodes
In addition to checking the quality of torrents in a feed, ma...
#123
opened Nov 14, 2018 by
ryankeefe92
Open
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Author
Label
Projects
Milestones
Assignee
Sort
Issues list
When adding torrent hash codes to blacklist, it will add the first hash, then put the second on the line above it, but then it deletes the second hash, then it just goes back and forth between re-adding and deleting the second hash code. This prevents a working .torrent from being found
bug
grabTorrent:
process:
Instead of having a “queue” (the downloadComplete directory), just have a single folder for completed downloads, and the processing subroutine can be run on specific files rather than running it on whatever file is in the processing directory. This would also allow more than one file to process at a time.
code efficiency
moveHook:
process:
resumeTorrent:
speed
theStuckProcess:
Rename transmission executables in the Episodes resource directory something else, so when the pkill command is executed on that new filename, it will kill only the processes started by the Episodes app
applicationShouldTerminate: & appQuit:
applicationWill/DidFinishLaunching:
preventative
resumeTorrent:
Expand “blacklist” to include the hashes for torrents that cause other types of problems besides just being zero bytes…ie, they won't open (an "on error" after the do shell script line, maybe?), they produce an mkv file that can’t be processed, etc
error handling
grabTorrent:
preventative
theStuckProcess:
If stuckProcess subroutine moves file to DownloadComplete, it should write the name of that file to a variable [a variable has been created, see 3/27/18 commit notes], which it will also check before moving files to DownloadComplete. That way, it knows if it is moving the file back a second time, and if it is, delete the file instead (and it's corresponding .torrent in the torrentadd directory), write the hash for the torrent the file was downloaded from to the "blacklist" fetch a new feed item for that episode, so it won't just keep moving the same file that won't process back and forth between Processing and DownloadComplete. It should do the same thing if the Process: subroutine throws an error.
error handling
grabTorrent:
preventative
process:
theStuckProcess:
Previous Next
ProTip!
Find all open issues with in progress development work with linked:pr.