-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify CI, fix cargo test, and fix docstrings #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful, been wanting to do this as well!
Huh, thought I responded to this via email. Super appreciate this! It all looks good to me and I think just needs a formatting pass to satisfy the PR checks here. Happy to merge after that. :) |
hmm. When I run |
shrug Beats me - but it passes it now and that's good enough for me. I might go ahead and cut a new point release for this just so anyone looking at docs has your work here visible - and then I think Seriously appreciate this PR! |
hey hey, saw some of the cool stuff with objc2 coming into this repo so I figured I'd throw in some help that's independent of the objc2 changes.
This PR updates:
cargo test
which builds all the examples and their rust in docstrings.#[cfg(feature = "foo")]
for examples that require feature foo (which are used in uikit and webview).I figure this will enable us to have tests and prevent things like #32 are less likely to happen.