-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiling for iOS #46
Conversation
@madsmtm Curious if you have any idea offhand why (The sheer number of files changed is also, admittedly, concerning, lol) |
Nightly vs. stable |
Huh. I am surprised by how much difference there is. Also, I like the |
@@ -7,7 +7,7 @@ Since this needs to run in an iOS simulator or on a device, you can't run it lik | |||
- Start a simulator (Simulator.app). | |||
- `cargo install cargo-bundle` | |||
- `cargo bundle --example ios-beta --no-default-features --features uikit,autolayout --target x86_64-apple-ios` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add this to CI in a new github job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably makes sense to do so, yeah - that way we'll know if I break it again ;)
Did this in #29 (comment) because it matched the previous output better (~= smaller diff). See |
Hmmm, amusingly enough I've never considered how linking something iOS-specific on a GitHub action would work. If anyone's got ideas or done it before I'm all ears, otherwise I'll have to take a look this weekend - made two basic attempts but I'm probably missing something hella obvious. |
This is a new CI error for me. I've not used the |
- uses: actions-rs/cargo@v1 | ||
with: | ||
command: build | ||
target: x86_64-apple-ios | ||
args: --example ios-beta --no-default-features --features uikit,autolayout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell, the build error you got in CI is the same as what I got when I ran cargo build --example ios-beta --no-default-features --features uikit,autolayout
(notice the lack of --target x86_64-apple-ios
). I think it needs to be done in the args
section similar to how the use-cross section of the
actions-rs/cargo` references.
Closing since this was addressed/rolled in #48. |
Block off the
animator
proxy pieces forappkit
/macos
to fix iOS compiling. Animation support was exploratory to begin with, and the iOS APIs are different enough that they'd need some thinking through anyway.