Adds confirmation dialog upon clicking the trash icon in the ledger t…

…able.
ryanml · Feb 27, 2018 · 53a414e · 53a414e
1 parent b0542c8
commit 53a414e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/app/extensions/brave/locales/en-US/preferences.properties b/app/extensions/brave/locales/en-US/preferences.properties
@@ -50,6 +50,7 @@ autoplay=Autoplay Media
 autoSuggestSites=auto-include
 backupLedger=Backup your wallet
 balanceRecovered={{balance}} was recovered and transferred to your Brave wallet.
+banSiteConfirmation=Are you sure you want to delete this site?
 beta=beta
 bitcoin=Bitcoin
 bitcoinBalance=Please transfer:&nbsp;

diff --git a/app/locale.js b/app/locale.js
@@ -233,6 +233,7 @@ var rendererIdentifiers = function () {
     'dappDetected',
     'dappDismiss',
     'dappEnableExtension',
+    'banSiteConfirmation',
     // other
     'passwordsManager',
     'extensionsManager',

diff --git a/app/renderer/components/preferences/payment/ledgerTable.js b/app/renderer/components/preferences/payment/ledgerTable.js
@@ -26,6 +26,7 @@ const getSetting = require('../../../../../js/settings').getSetting
 const aboutActions = require('../../../../../js/about/aboutActions')
 const urlUtil = require('../../../../../js/lib/urlutil')
 const {SettingCheckbox, SiteSettingCheckbox} = require('../../common/settings')
+const locale = require('../../../../../js/l10n')
 
 class LedgerTable extends ImmutableComponent {
   get synopsis () {
@@ -100,7 +101,10 @@ class LedgerTable extends ImmutableComponent {
   }
 
   banSite (hostPattern) {
-    aboutActions.changeSiteSetting(hostPattern, 'ledgerPaymentsShown', false)
+    const confMsg = locale.translation('banSiteConfirmation')
+    if (window.confirm(confMsg)) {
+      aboutActions.changeSiteSetting(hostPattern, 'ledgerPaymentsShown', false)
+    }
   }
 
   togglePinSite (hostPattern, pinned, percentage) {