Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
font-patcher: Fix glyphs with overlap
[why] For some powerline symbols we add a certain amount of overlap into the previous or next character to cover up a small gap between the symbols that otherwise can show up as ugly thin (usually colored) line. But after we carefully design that glyph with a bit overlap (over-sized and having negative bearings) we remove all bearings. That breaks of course the glyph and no actual overlap on the left side happens. [how] Just do not remove negative bearings on overlap-enabled glyphs. As they are rescaled in both directions anyhow all bearings are wanted and must be kept. Reported-by: Mihail Ivanchev <@MIvanchev> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
- Loading branch information
f528ffb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reporter here, this has to be the quickest reaction I've ever experienced, I have been looking for the source of this bug (odity?) for a long time now, thanks :)
f528ffb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other thing I could have done this morning involves several badly designed C++ classes that I want to access through a class template; the loosely related 'bases' differ in small details but that breaks the template and because I am not allowed to use C++17 the easy
if constexp
is not possible and every one line in my head needs to be translated into 10 lines of C++14 code, and ... well, morale is low. *sigh*Regarding the
font-patcher
, bad is that the order ofset_glyph_width_mono()
andremove_glyph_neg_bearings()
is also wrong (i.e. has been deliberately broken) -> #764