-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nerd Fonts nonMono not selectable with Windows Terminal #1098
Comments
5170911 SIGH |
[why] Some fonts have invalid (or unset) Panose flags. When we create a "Nerd Font Mono" font the Panose proportion is set to 'monospace'. This make the font selectable in certain applications that need monospaced fonts. After #764 the "Nerd Font" variant shall (again) be detected as monospaced font, but the glyphs have a big right side bearing (hang into the next 'cell'). So we need to set the Panose bits there also. [how] We already have a check if the font is propably monospaced, independent from Panose. This is used to prevent --mono patching on originally proportional fonts. If we find out with that check that the font is (most probably) monospaced we also set the appropriate bits in Panose; unless Panose has valid values that contradict that change. Fixes: #1098 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@237dmitry Thanks for the information. You have the And we tracked it down to be a glitch in the Anyhow, added code that autocorrects bad/wrong/missing Panose flags. |
With unchecked |
Not if they have correct Panose information? Edit: Remove wrong image |
Here, the 4 fonts just created by
("all fonts" still unselected), note version You see, no problem with Edit: Sorry finishing edit only now, because ... I can not work on that Windows machine, it drives me crazy (because it runs in 'Germany' mode which is ridiculous |
Sorry, but I don't know what |
Fonts have much more information stored than the Font Manager is able to show. And then there are tables that stem from different companies (i.e. Adobe/Apple/Microsoft as the big ones) that store 'almost similar but different' information. To cite Yannis Haralambous:
Panose links |
[why] Some fonts have invalid (or unset) Panose flags. When we create a "Nerd Font Mono" font the Panose proportion is set to 'monospace'. This make the font selectable in certain applications that need monospaced fonts. After ryanoasis#764 the "Nerd Font" variant shall (again) be detected as monospaced font, but the glyphs have a big right side bearing (hang into the next 'cell'). So we need to set the Panose bits there also. [how] We already have a check if the font is propably monospaced, independent from Panose. This is used to prevent --mono patching on originally proportional fonts. If we find out with that check that the font is (most probably) monospaced we also set the appropriate bits in Panose; unless Panose has valid values that contradict that change. Fixes: ryanoasis#1098 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
[why] Some fonts have invalid (or unset) Panose flags. When we create a "Nerd Font Mono" font the Panose proportion is set to 'monospace'. This make the font selectable in certain applications that need monospaced fonts. After ryanoasis#764 the "Nerd Font" variant shall (again) be detected as monospaced font, but the glyphs have a big right side bearing (hang into the next 'cell'). So we need to set the Panose bits there also. [how] We already have a check if the font is propably monospaced, independent from Panose. This is used to prevent --mono patching on originally proportional fonts. If we find out with that check that the font is (most probably) monospaced we also set the appropriate bits in Panose; unless Panose has valid values that contradict that change. Fixes: ryanoasis#1098 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
🗹 Requirements
🎯 Subject of the issue
Experienced behavior:
After installing
only the
Nerd Font Mono
variants are visible in Windows Terminal, when not selectingall fonts
.This is possibly a regression, I believe this had been fixed before.
They ARE selectable with Gnome-Terminal which is also picky sometimes.
Expected behavior:
Can select all 4
Example symbols:
🔧 Your Setup
Anonymice Powerline Nerd Font Complete.ttf
)?See above
Release zip 2.3.3
iterm2
,urxvt
,gnome
,konsole
)?Windows Terminal 1.15.3466.0
Windows 10 no wait 11
★ Screenshots (Optional)
The text was updated successfully, but these errors were encountered: