Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent size for weather-symbols #1107

Closed
3 tasks done
Bacaliu opened this issue Feb 5, 2023 · 9 comments · Fixed by #1109
Closed
3 tasks done

Inconsistent size for weather-symbols #1107

Bacaliu opened this issue Feb 5, 2023 · 9 comments · Fixed by #1109

Comments

@Bacaliu
Copy link

Bacaliu commented Feb 5, 2023

🗹 Requirements

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:

The Weathersymbols aren't the same size dependent on if they rain or not and if they have the sun in them or not. Even with multiple spaces after them they don't grow horizontally like in previous versions.

Expected behavior:

In Version 2.2.2-2 (which is installed on my local system) when a space was inserted right next to the symbols, they would grow to give the sunbeams more horizontal space which made them very much the same size as the equivalent symbol for night. Showers would shift the cloud and sun slightly up so they could stay the same size as a cloud without rain.

Example symbols:

  •  
  •  
  •  
  •  

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    • Symbols-2048-em Nerd Font Complete.ttf
    • Symbols-2048-em Nerd Font Complete Mono.ttf
  • Where did you get the file from (download link, self patched, source downloaded from link...)
    • download link
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
    • None. I use the Font on my website.
  • Are you using OS X, Linux or Windows? And which specific version or distribution?
    • Doesn't matter
      • Laptop: Arch Linux 6.1.9-arch1-1
      • Server: Debian 11.6
      • Client: any

★ Screenshots (Optional)

v2.2.2-2 [as expected, very uniform size]
grafik

v2.3.3 [sun with rain is to small]
grafik

v2.3.3, Mono [much worse]
grafik

@Finii Finii added the confirmed label Feb 5, 2023
@Finii
Copy link
Collaborator

Finii commented Feb 5, 2023

image

Strange, should have been fixed by

Examining...

@Finii
Copy link
Collaborator

Finii commented Feb 5, 2023

Ahh,

        WEATH_SCALE_LIST = {'ScaleGroups': [
            range(0xf095, 0xf0b0 + 1), # moon phases
            range(0xf0b7, 0xf0c3 + 1), # wind strengths
            range(0xf053, 0xf055 + 1), # thermometer
            [0xf06e, 0xf070 ], # solar eclipse
            [0xf042, 0xf045 ], # degree sign
        ]}

Obviously there is no rule for the clouds 😬

@Finii
Copy link
Collaborator

Finii commented Feb 5, 2023

The real reason is

as they are individually down-scaled.

This is in fact a problem. Needs some thinking.

@Finii
Copy link
Collaborator

Finii commented Feb 8, 2023

@Bacaliu

v2.3.3, Mono [much worse]

Can you explain the 'much worse' part here? Worse because of what? What is actually bad?

@Finii
Copy link
Collaborator

Finii commented Feb 8, 2023

Maybe you can also explain a bit your use case.

That glyphs 'grow' depending on amount of blanks after them is a very client (terminal emulator) specific behavior.

Finii added a commit that referenced this issue Feb 8, 2023
[why]
The scaling of the clouds is not identical but depends on the actual
glyph bounding box. But the clouds should all have the same scaling to
be 'interchangeable'

[how]
Put all clouds in a ScaleGroup.

Also add missing Celsius degrees glyph to other degree glyphs group.

Fixes: #1107

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit that referenced this issue Feb 8, 2023
[why]
The scaling of the clouds is not identical but depends on the actual
glyph bounding box. But the clouds should all have the same scaling to
be 'interchangeable'

[how]
Put all clouds in a ScaleGroup.

Also add missing Celsius degrees glyph to other degree glyphs group.

Fixes: #1107

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator

Finii commented Feb 8, 2023

After fix we have all clouds the same size (left old, right new; blue line above means: changed)

image

The biggest icons are right in the beginning, 'strong wind with sun behind clouds' or something, and all other clouds need to be equally small to preserve size-equality.

@Finii
Copy link
Collaborator

Finii commented Feb 8, 2023

Maybe these belong to the same set?

image

That would mean adding them to the group and they will come out smaller.

Edit: Or are all the circled glyphs an independent group and the bottom one should be bigger? 🤔

@Bacaliu
Copy link
Author

Bacaliu commented Feb 8, 2023

Can you explain the 'much worse' part here? Worse because of what? What is actually bad?

In the Mono Font the sizes are different for day or night; that looks more bad than just rain making the cloud smaller. If displaying multiple symbols for different daytimes next to each other the difference in size is very obvious.

Maybe you can also explain a bit your use case.

I use the symbols to display a weather forecast:

grafik

...
<div class="weather-column-cell" style="line-height: 1.75;
  background: linear-gradient(
  #76b3d5,
  30%,
  #6fb8e0,
  30%,
  #6fb8e0,
  60%,
  #7dadca,
  60%,
  #7dadca,
  85%,
  #5fc6f8
  85%,
  #5fc6f8
); border-radius: 2em;" title="stark bewölkt">
  <span class="nf" style="font-size: 1.3rem; text-align: center; margin-left: 0.5rem;
                color: black;"></span>
</div>
...

I just put the icon inside a div with a gradient representing the sky.

That glyphs 'grow' depending on amount of blanks after them is a very client (terminal emulator) specific behavior.

I suspected that because they grow differently in Emacs/Kitty/Browser. Just thought there was a /right/ way of growing.

The fixed version looks much better to me. Although I'm not sure if the most used cloud only or even sun/moon should be at the same location and have the same size. But looking at the svg versions on erikflowers/weather-icons it seems to be intended that e.g. wi-day-sunny or wi-day-sunny-overcast are not exactly aligned and sized with the others.

Edit: Or are all the circled glyphs an independent group and the bottom one should be bigger?

Looking on linked site the top four belong together (no weather-information, just rise/set) and the lower two (day-hot and day-haze)

Finii added a commit that referenced this issue Feb 13, 2023
[why]
The scaling of the clouds is not identical but depends on the actual
glyph bounding box. But the clouds should all have the same scaling to
be 'interchangeable'

[how]
Put all clouds in a ScaleGroup.

Also add missing Celsius degrees glyph to other degree glyphs group.

Fixes: #1107

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit that referenced this issue Feb 15, 2023
[why]
The scaling of the clouds is not identical but depends on the actual
glyph bounding box. But the clouds should all have the same scaling to
be 'interchangeable'

[how]
Put all clouds in a ScaleGroup.

Also add missing Celsius degrees glyph to other degree glyphs group.

Fixes: #1107

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit that referenced this issue Feb 15, 2023
[why]
The scaling of the clouds is not identical but depends on the actual
glyph bounding box. But the clouds should all have the same scaling to
be 'interchangeable'

[how]
Put all clouds in a ScaleGroup.

Also add missing Celsius degrees glyph to other degree glyphs group.

Fixes: #1107

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit to b-/nerd-fonts that referenced this issue Feb 17, 2023
[why]
The scaling of the clouds is not identical but depends on the actual
glyph bounding box. But the clouds should all have the same scaling to
be 'interchangeable'

[how]
Put all clouds in a ScaleGroup.

Also add missing Celsius degrees glyph to other degree glyphs group.

Fixes: ryanoasis#1107

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
[why]
The scaling of the clouds is not identical but depends on the actual
glyph bounding box. But the clouds should all have the same scaling to
be 'interchangeable'

[how]
Put all clouds in a ScaleGroup.

Also add missing Celsius degrees glyph to other degree glyphs group.

Fixes: ryanoasis#1107

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants