-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent size for weather-symbols #1107
Comments
Strange, should have been fixed by Examining... |
Ahh, WEATH_SCALE_LIST = {'ScaleGroups': [
range(0xf095, 0xf0b0 + 1), # moon phases
range(0xf0b7, 0xf0c3 + 1), # wind strengths
range(0xf053, 0xf055 + 1), # thermometer
[0xf06e, 0xf070 ], # solar eclipse
[0xf042, 0xf045 ], # degree sign
]} Obviously there is no rule for the clouds 😬 |
The real reason is as they are individually down-scaled. This is in fact a problem. Needs some thinking. |
Can you explain the 'much worse' part here? Worse because of what? What is actually bad? |
Maybe you can also explain a bit your use case. That glyphs 'grow' depending on amount of blanks after them is a very client (terminal emulator) specific behavior. |
[why] The scaling of the clouds is not identical but depends on the actual glyph bounding box. But the clouds should all have the same scaling to be 'interchangeable' [how] Put all clouds in a ScaleGroup. Also add missing Celsius degrees glyph to other degree glyphs group. Fixes: #1107 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] The scaling of the clouds is not identical but depends on the actual glyph bounding box. But the clouds should all have the same scaling to be 'interchangeable' [how] Put all clouds in a ScaleGroup. Also add missing Celsius degrees glyph to other degree glyphs group. Fixes: #1107 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
In the Mono Font the sizes are different for day or night; that looks more bad than just rain making the cloud smaller. If displaying multiple symbols for different daytimes next to each other the difference in size is very obvious.
I use the symbols to display a weather forecast: ...
<div class="weather-column-cell" style="line-height: 1.75;
background: linear-gradient(
#76b3d5,
30%,
#6fb8e0,
30%,
#6fb8e0,
60%,
#7dadca,
60%,
#7dadca,
85%,
#5fc6f8
85%,
#5fc6f8
); border-radius: 2em;" title="stark bewölkt">
<span class="nf" style="font-size: 1.3rem; text-align: center; margin-left: 0.5rem;
color: black;"> </span>
</div>
... I just put the icon inside a div with a gradient representing the sky.
I suspected that because they grow differently in Emacs/Kitty/Browser. Just thought there was a /right/ way of growing. The fixed version looks much better to me. Although I'm not sure if the most used cloud only or even sun/moon should be at the same location and have the same size. But looking at the svg versions on erikflowers/weather-icons it seems to be intended that e.g.
Looking on linked site the top four belong together (no weather-information, just rise/set) and the lower two (day-hot and day-haze) |
[why] The scaling of the clouds is not identical but depends on the actual glyph bounding box. But the clouds should all have the same scaling to be 'interchangeable' [how] Put all clouds in a ScaleGroup. Also add missing Celsius degrees glyph to other degree glyphs group. Fixes: #1107 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] The scaling of the clouds is not identical but depends on the actual glyph bounding box. But the clouds should all have the same scaling to be 'interchangeable' [how] Put all clouds in a ScaleGroup. Also add missing Celsius degrees glyph to other degree glyphs group. Fixes: #1107 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] The scaling of the clouds is not identical but depends on the actual glyph bounding box. But the clouds should all have the same scaling to be 'interchangeable' [how] Put all clouds in a ScaleGroup. Also add missing Celsius degrees glyph to other degree glyphs group. Fixes: #1107 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] The scaling of the clouds is not identical but depends on the actual glyph bounding box. But the clouds should all have the same scaling to be 'interchangeable' [how] Put all clouds in a ScaleGroup. Also add missing Celsius degrees glyph to other degree glyphs group. Fixes: ryanoasis#1107 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
[why] The scaling of the clouds is not identical but depends on the actual glyph bounding box. But the clouds should all have the same scaling to be 'interchangeable' [how] Put all clouds in a ScaleGroup. Also add missing Celsius degrees glyph to other degree glyphs group. Fixes: ryanoasis#1107 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
🗹 Requirements
🎯 Subject of the issue
Experienced behavior:
The Weathersymbols aren't the same size dependent on if they rain or not and if they have the sun in them or not. Even with multiple spaces after them they don't grow horizontally like in previous versions.
Expected behavior:
In Version 2.2.2-2 (which is installed on my local system) when a space was inserted right next to the symbols, they would grow to give the sunbeams more horizontal space which made them very much the same size as the equivalent symbol for night. Showers would shift the cloud and sun slightly up so they could stay the same size as a cloud without rain.
Example symbols:
🔧 Your Setup
Anonymice Powerline Nerd Font Complete.ttf
)?Symbols-2048-em Nerd Font Complete.ttf
Symbols-2048-em Nerd Font Complete Mono.ttf
iterm2
,urxvt
,gnome
,konsole
)?★ Screenshots (Optional)
v2.2.2-2 [as expected, very uniform size]
v2.3.3 [sun with rain is to small]
v2.3.3, Mono [much worse]
The text was updated successfully, but these errors were encountered: