-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codepoint screenshot for Patched/Complete Octoicons #116
Comments
@kaymmm Hey thanks for this I do appreciate it 😄 Sorry for the delay. We have been hard at work on v1.0.0 😄
Yeah... and this has caused confusion before... which is clearly understandable. I had been wanting to change this on the readme as well so I agree 100%
Again I agree with this. README should have the codepoints for the 'complete' variation and maybe below a link to the Wiki to view the original codepoints. Something like that I think you are saying. I envision it as something like this: Octicons
Nerd Font Complete Codepoints:** To avoid conflicts between icon sets these were modified. To view the original codepoints see the Wiki Any thoughts? I am open to any suggestions that make things better and easier 😄 |
I like your idea. My only suggestion is to be explicit which versions of the fonts use these codepoints. Perhaps something like: "To avoid conflicts between icon sets, these were modified in the 'Complete' fonts. To view the original codepoints see the Wiki." |
Thanks, we'll go with that |
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
Add codepoint screenshot for Patched/Complete Octoicons
The codepoints for the octoicons in the complete sets are moved to avoid clashing with the FontAwesome code points, but the README doesn't make mention of this (I discovered this via the Powerlevel9k git issues). It doesn't make sense to have two screenshots on the README with both sets of codepoints, but maybe it could go in the Wiki? I've attached a Font Forge screenshot that mirrors the one in the README but shifted for the Patched/Complete fonts.
The text was updated successfully, but these errors were encountered: