Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nerd Font Mono some glyphs too wide #1198

Closed
3 tasks done
Finii opened this issue May 3, 2023 · 3 comments · Fixed by #1199
Closed
3 tasks done

Nerd Font Mono some glyphs too wide #1198

Finii opened this issue May 3, 2023 · 3 comments · Fixed by #1199

Comments

@Finii
Copy link
Collaborator

Finii commented May 3, 2023

🗹 Requirements

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

🎯 Subject of the issue

This has been reported by @jimeh via Gitter.

Experienced behavior:

image

Expected behavior:
Glyphs should not extend out of the 'cell' for Nerd Font Mono.

The patcher also complains:

Adding 169 Glyphs from Octicons Set
╢█████████████████████████████░░░░░░░░░░░╟ 72%WARNING: Scaled glyph F478 wider than one monospace width (1410 / 1233 (overlap None))
╢█████████████████████████████░░░░░░░░░░░╟ 72%WARNING: Scaled glyph F479 wider than one monospace width (1407 / 1233 (overlap None))
╢████████████████████████████████████████╟ 100%

Example symbols:

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    • Please give the full filename
  • Where did you get the file from (download link, self patched, source downloaded from link...)
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
  • Are you using OS X, Linux or Windows? And which specific version or distribution?

★ Screenshots (Optional)

@Finii
Copy link
Collaborator Author

Finii commented May 3, 2023

Octicons originates in F000 and is patched into F400...

        OCTI_SCALE_LIST = {'ScaleGlyph': 0xF02E, # looking glass (probably biggest glyph?)
            'GlyphsToScale': [
                (0xf03d, 0xf040), # arrows
                0xf044, 0xf05a, 0xf05b, 0xf0aa, # triangles
                (0xf051, 0xf053), # small stuff
                0xf071, 0xf09f, 0xf0a0, 0xf0a1, # small arrows
                0xf078, 0xf0a2, 0xf0a3, 0xf0a4, # chevrons
                0xf0ca, # dash

F478 (F078) does not look like a chevron, what happened here?

@Finii
Copy link
Collaborator Author

Finii commented May 3, 2023

  1. It is patched with gaps filled, so codepoints F000 do not match exactly to F400...
  2. It's a 'small arrow'

The small arrows have been dropped are were replaced... but I forget (did not realize) to remote their SCALE GROUP

image

Finii added a commit that referenced this issue May 3, 2023
[why]
With the Octicons update some codepoint contents changed.
Also some symbols scale still wrong.

[how]
Check fonts and add / drop entries.
Use GlyphsToScale+ to correct position of Github text icon.

Fixes: #1198

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii mentioned this issue May 3, 2023
2 tasks
Finii added a commit that referenced this issue May 3, 2023
[why]
With the Octicons update some codepoint contents changed.
Also some symbols scale still wrong.

[how]
Check fonts and add / drop entries.
Use GlyphsToScale+ to correct position of Github text icon.

Fixes: #1198

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Copy link
Contributor

github-actions bot commented Nov 6, 2023

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
[why]
With the Octicons update some codepoint contents changed.
Also some symbols scale still wrong.

[how]
Check fonts and add / drop entries.
Use GlyphsToScale+ to correct position of Github text icon.

Fixes: ryanoasis#1198

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant