Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cod-debug-continue-small is not small #1214

Closed
3 tasks
Finii opened this issue May 8, 2023 · 3 comments · Fixed by #1216
Closed
3 tasks

cod-debug-continue-small is not small #1214

Finii opened this issue May 8, 2023 · 3 comments · Fixed by #1216

Comments

@Finii
Copy link
Collaborator

Finii commented May 8, 2023

🗹 Requirements

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:

Screenshot 2023-05-08 at 06 30 25

Maybe there are more

Expected behavior:

Example symbols:

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    • Please give the full filename
  • Where did you get the file from (download link, self patched, source downloaded from link...)
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
  • Are you using OS X, Linux or Windows? And which specific version or distribution?

★ Screenshots (Optional)
@Finii Finii added this to the v3.0.1 milestone May 8, 2023
@Finii
Copy link
Collaborator Author

Finii commented May 8, 2023

image

Finii added a commit that referenced this issue May 8, 2023
@Finii
Codicons: Preserve smaller icons
738034c 
[why]
The codicons have 3 obvious (from the name) pairs of regular and small
icons. The size difference is slight but visible.

When we maximize all individual icons the differences are mostly lost.

[how]
Put each pair into one ScaleGroup to keep their individual scaling.

Fixes: #1214

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii mentioned this issue May 8, 2023
Merged
2 tasks
@Finii Finii removed this from the v3.0.1 milestone May 8, 2023
@Finii
Copy link
Collaborator Author

Finii commented May 10, 2023

Closed via #1216

@Finii Finii closed this as completed May 10, 2023
Finii added a commit that referenced this issue May 12, 2023
@Finii
Codicons: Preserve smaller icons
9299ba5 
[why]
The codicons have 3 obvious (from the name) pairs of regular and small
icons. The size difference is slight but visible.

When we maximize all individual icons the differences are mostly lost.

[how]
Put each pair into one ScaleGroup to keep their individual scaling.

Fixes: #1214

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit that referenced this issue May 12, 2023
@Finii
Codicons: Preserve smaller icons
43b9ae1 
[why]
The codicons have 3 obvious (from the name) pairs of regular and small
icons. The size difference is slight but visible.

When we maximize all individual icons the differences are mostly lost.

[how]
Put each pair into one ScaleGroup to keep their individual scaling.

Fixes: #1214

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
@Finii
Codicons: Preserve smaller icons
07894d1 
[why]
The codicons have 3 obvious (from the name) pairs of regular and small
icons. The size difference is slight but visible.

When we maximize all individual icons the differences are mostly lost.

[how]
Put each pair into one ScaleGroup to keep their individual scaling.

Fixes: ryanoasis#1214

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Codicons: Preserve smaller icons ryanoasis/nerd-fonts
1 participant
@Finii