-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance User Experience: Improve Access to GitHub Repository Link #1372
Comments
Both solutions look nice. And the tiny github cat is really cute! Much better than the diagonal banner. But then it just allows an easy path to the github repo and does not say that we love to be forked. As further input, I believe only very few people will ever follow that link, so it is maybe not needed to have it prominent and/or always accessible. And the fork banner already allows to immediately fork: |
Hey @Finii, I appreciate your feedback on both solutions. Best regards, |
I would be grateful!
…________________________________
From: Vitthal Popat Gund ***@***.***>
Sent: Sunday, 8 October 2023 11:16
To: ryanoasis/nerd-fonts
Cc: Fini; Comment
Subject: Re: [ryanoasis/nerd-fonts] Enhance User Experience: Improve Access to GitHub Repository Link (Issue #1372)
Hey,
I appreciate your feedback on both solutions.
I believe the tiny GitHub cat icon is a subtle but effective way to provide access to the repository for contributors. It balances accessibility and user-friendliness.
May I proceed with the tiny GitHub cat icon as our solution?
Best regards,
Vitthal Gund
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
Hey @Finii, It seems I accidentally unassigned myself from the issue. My apologies for the oversight. I'm still actively working on it and would like to be reassigned. Thank you. |
Inside the div container github icon is added with link to master branch Fixes: ryanoasis#1366 Fixes: ryanoasis#1372
Implement GitHub Icon for Improved Accessibility to Repository - Issue #1372
Solved via #1373 |
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
Requirements
Is your feature request related to a problem? Please describe.
As part of our discussion, we identified a user experience issue with the "Fork-me" banner on smaller screens. The banner becomes problematic, and accessing the GitHub repository can be inconvenient for users.
Describe the solution(s) you'd like
We propose two solutions to enhance the user experience:
Solution 1: Drop the "Fork-me" banner when it starts to be a problem on very small screens. Replace it with a 'Visit GitHub Repository' button just below the 'number of stars' and 'forks.' This will provide an easily accessible link for users, regardless of screen size.
Solution 2: Add a GitHub icon on the bottom left corner with some margin and padding. This icon will serve as a persistent and easily accessible link to the GitHub repository. Users can click the icon to visit the repository no matter where they are on the page, eliminating the need to scroll back up.
We are open to considering either solution based on community feedback and preferences.
Additional context
We also identified an issue with the link in the "Fork-me" banner leading to the gh-pages branch instead of the default (master) branch. This issue has been addressed and corrected with the following link: https://github.com/ryanoasis/nerd-fonts/tree/master.
Screenshots
Before:
After:
Assign me this issue.
If you have any questions or need further information, please feel free to ask.
The text was updated successfully, but these errors were encountered: