Patcher: explain the mono option better

[Taverius]

Nowhere does it say you need it for Mac/Win GVim to pick up the fonts :)

Had me scratching my head for an hour or so, looking at various topics on SO, before I happened on the a closed issue that mentions this.

[ryanoasis]

@Taverius Sorry about that.

We tried to explain better in some of the markdown files, for example: AnonymousPro

Can I ask which closed issue you are referring to? 😊

you need it for Mac/Win GVim to pick up the fonts

Hmm it shouldn't be required but lately with the GUI builds of Vim there is an ambiguous width issue (glyphs cut in half). What was the issue? The fonts weren't working at all unless you used the mono versions?

explain the mono option better

I am all for this 😄. Did you have any specific place where more info would have helped? The readme? The patcher (--help) ? Somewhere else?

[Taverius]

Hmm it shouldn't be required but lately with the GUI builds of Vim there is an ambiguous width issue (glyphs cut in half). What was the issue? The fonts weren't working at all unless you used the mono versions?

The latter, now working at all, GVim just wasn't seeing them - I'm running a very recent 8.0.

So its a 'lately' thing? Hopefully upstream is aware and someone who understands the codebase can do something about it.

As for explaining, the --help sounds like a decent place for such a hint - about it being sometimes useful to get certain editors to see the font on mac/win - but it also might make the option text too bloated ... up to you.

I'm just trying to save some time for anyone else who wants to patch Consolas/Input on non-(li|u)nix.

Pointless edit: looked at the .md, and yup, it explains it, but that's probably not a file someone just wanting to patch a font will look at. Also, amusingly, ConEmu had no problem whatsoever with the double-width fonts :S

[RuRo]

In my opinion, the correct place for such explanations is the README.md. There are on the other hand things in the README that shouldn't be there cough images with wrong character codes cough.
If nobody does anything about this before the 27th, I can try to 'refactor' the Readme.md

In fact, I would put the only the bare minimum in the --help like command line arguments description and a static link to the README hosted on github for that particular version. After all, unless the user wants to install all the fonts or to patch them themselves for some reason, I think, most users would just download the already patched font, so there would be no --help message for them.

[ryanoasis]

@RuRo I agree readme would best.

images with wrong character codes

Do you mean the "Seti-UI + Custom" set and "Font Awesome Extension" set? 😊

If nobody does anything about this before the 27th, I can try to 'refactor' the Readme.md

Sure I am always open to PRs 😄

Honestly I haven't made much progress lately on getting the next release (v1.1) out the door.. but I don't think there is much left to do. Possibly this weekend but I'd hate to promise 😊

[luisdavim]

More info on the README would be great.
For example, I have no idea what the difference between variations, like with these:

Ubuntu Mono Nerd Font Complete Mono Windows Compatible.ttf
Ubuntu Mono Nerd Font Complete Mono.ttf
Ubuntu Mono Nerd Font Complete Windows Compatible.ttf
Ubuntu Mono Nerd Font Complete.ttf
Ubuntu Mono derivative Powerline Nerd Font Complete Mono Windows Compatible.ttf
Ubuntu Mono derivative Powerline Nerd Font Complete Mono.ttf
Ubuntu Mono derivative Powerline Nerd Font Complete Windows Compatible.ttf
Ubuntu Mono derivative Powerline Nerd Font Complete.ttf

[ryanoasis]

@luisdavim Yes you are right.

This should now mostly be taken care of now with: b5e8271 and https://github.com/ryanoasis/nerd-fonts/wiki/FAQ-and-Troubleshooting#tldr

[luisdavim]

thanks. and what about the fonts that have powerline in their names? They all seem to have the powerline glyphs anyway...

[ryanoasis]

Yeah good point. Those are originally from https://github.com/powerline/fonts

Either we should upgrade the unpatched fonts to remove the 'for Powerline'/'powerline' or filter that out in the patcher.

[ryanoasis]

Considering this closed (with v1.1.0 release)

[github-actions]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.