Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material Design Icons missing some icons #279

Closed
Hnaguski opened this issue Jun 23, 2018 · 13 comments · Fixed by #773
Closed

Material Design Icons missing some icons #279

Hnaguski opened this issue Jun 23, 2018 · 13 comments · Fixed by #773

Comments

@Hnaguski
Copy link

🎯 Subject of the issue

It appears that some of the icons from the Material Design Icons set are missing, the ones I've found to be missing are:

  • battery-charging-outline
  • battery-charging-10
  • battery-charging-50
    The icons are not listed in the cheat sheet on the nerd-fonts website but they are on the MDI website if you search for 'charging'

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    Sauce Code Pro Nerd Font Complete.ttf
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
    st
  • Are you using OS X, Linux or Windows? And which specific version or distribution?
    Debian 9 Testing

★ Optional

As you can see there are missing icons here
Missing Icons on website

Here are what all the charging icons should be
All the correct icons

@ryanoasis
Copy link
Owner

Thanks for bringing this up, I am trying to get my arms back around Nerd Fonts 😈

@MaienM
Copy link

MaienM commented Aug 16, 2018

All of the wifi strength icons also seem to be missing (for example wifi-strength-0).

@joachimnielandt
Copy link

I'd like to see the wifi-strength icons as well! Very much liking the nerd-fonts packaging so far.

@hanskokx
Copy link

I'm running into this too.

Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
Hack Regular Nerd Font Complete.ttf
Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
FluentTerminal
Are you using OS X, Linux or Windows? And which specific version or distribution?
Windows 10 Pro October 2018 update => WSL (Ubuntu 18.04.1 LTS)

@maxnordlund
Copy link

Same here, Sauce Code Pro Complete, iTerm2, OS X. I thought I should make a PR but I can't grok how this works. Then there's the question of existing code points, since you don't want to break old stuff. I'm not sure to amend a couple of runes like this.

Also, thank you for this awesome package, makes my daily life much nicer ❤️

@NomisIV
Copy link

NomisIV commented May 26, 2020

This might be a necro bump, but I've done some research:

The reason the charging battery icons are missing is that the ttf-file from which the material design icons are copied from does not include them. I went upstream to search for them in their latest ttf-file, and successfully found them at U+F089C to U+F089F. I have also found better Wi-Fi symbols.

I will try to update the ttf-file and adjust the ranges between which the icons are stored. If it works, I'll gladly try to make a PR.

I have attached the new ttf-file below.
MaterialDesign-Webfont-master.zip

EDIT: The problem seems to be that there is not enough space without a major reshuffle of the characters. Alternatively, they could be added in the "Supplementary Private Use Area-A", which ranges from F0000 to FFFFF. However, this might not be desirable since not all applications support UTF-16, and I don't know how to convert UTF-8 fonts to UTF-16.

EDIT2: I've tried changing the SymStart and SymEnd of the icons (in font-patcher) to point into CJK Unified Ideogrpahs, but I could not get the script to include it. I did pass the --complete flag to font-patcher, and I did not get any error messages (that I've noticed) telling me what's wrong. If someone more experienced with the script could give me a hand it would really be helpful.

EDIT3: UTF-16 is not what I thought it was. I thought it was the latter half of the unicode codepoints (100000 and onwards), but actually it's a completely different encoding standard

@hanskokx
Copy link

hanskokx commented May 26, 2020 via email

@maxnordlund
Copy link

Indeed, some true detective work right there.

@NomisIV
Copy link

NomisIV commented May 31, 2020

I have dug around some more, and I now have a (not very good) fix. This repo is where I got the updated font where I found the missing symbols. I have been hesitant to download and install the TTF, as I am on arch and would rather find an AUR for it. Which is what I just found: here.

Yeah, that's the fix.

Since the font stores the glyphs in the private use area on plane 15, it can safely be used as any fallback font. However, in programs which does not load fallback fonts, or which only load a single font, or which cannot handle UTF-16 fonts, NerdFont is still the best bet.

For me this almost enough. I use alacritty for my terminal, and it seems to render the icons just fine. However, my statusbar (lemonbar) currently only supports UTF-8, and I have not got it working with the Material Design Font.

To conclude my research: it is not possible to add the missing symbols in a sensible way without a massive reshuffle of all glyphs, or without sacrificing other unicode categories (like CJK Unified Ideographs).

If anyone with some experience with the font-patcher could modify it to implement the reshulle and use the new Material Design Icons font, I would be very grateful. I do not care about backwards compatibilty. Could this new version be added as a separete branch?

@hanskokx
Copy link

hanskokx commented Jun 12, 2020 via email

@ryanoasis
Copy link
Owner

Yeah. A major reshuffle (perfect way to describe it by the way 👍) won't happen anytime soon and will be at 3.0 release. There were terrible choices (by me) for some of the codepoints and we are paying the price 😅

@Animeshz
Copy link

Animeshz commented Sep 6, 2021

chart-box and chart-box-outline are also missing 👀

@ryanoasis ryanoasis added this to the v3.0.0 milestone Dec 14, 2021
earboxer added a commit to earboxer/nerd-fonts that referenced this issue Jan 27, 2022
Finii pushed a commit to earboxer/nerd-fonts that referenced this issue Oct 6, 2022
Finii pushed a commit to earboxer/nerd-fonts that referenced this issue Jan 6, 2023
Finii pushed a commit to earboxer/nerd-fonts that referenced this issue Jan 7, 2023
Finii pushed a commit to earboxer/nerd-fonts that referenced this issue Jan 7, 2023
Finii pushed a commit to earboxer/nerd-fonts that referenced this issue Jan 13, 2023
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants