Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide license files for each patched font folder and include in future archives #463

Closed
4 tasks done
FredHappyface opened this issue Apr 10, 2020 · 11 comments
Closed
4 tasks done
Assignees

Comments

@FredHappyface
Copy link

🗹 Requirements

  • A brief but descriptive title of your issue
  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have read or scanned the FAQ
  • I have read or scanned the Wiki

🎯 Subject of the issue

I am unable to find the license.txt/ license.md for each patched font, however, these appear to be included in a previous release

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)? Any
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)? N/A
  • Are you using OS X, Linux or Windows? And which specific version or distribution? Windows 10

★ Optional

@FredHappyface
Copy link
Author

My bad, turns out they are under the unpatched font directory. Would it be possible for you to automate dumping these in the patched fonts directory?

@ryanoasis
Copy link
Owner

My bad, turns out they are under the unpatched font directory

No worries, yes!

Would it be possible for you to automate dumping these in the patched fonts directory?

Yes we could do that. Curious if you were just curious or you see some potential licensing issue?
It would probably be a good idea to error on the side of copying rather than not copying them.. they could/should probably also propagate to the downloadable archive zip file as well...

@polyzen
Copy link
Contributor

polyzen commented Apr 11, 2020

Generally licenses are required to be distributed along with what they're licensing.

@ryanoasis
Copy link
Owner

Thanks for looking out. Yeah there is a potentially major issue here.. I guess I know what I'll be working on next

@ryanoasis ryanoasis self-assigned this Apr 11, 2020
@ryanoasis
Copy link
Owner

This will be fixed in the archives from now on in any future releases. Also the licenses should now be present in the patched directories as siblings to the actual font files, for example: https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/BigBlueTerminal/complete

@polyzen
Copy link
Contributor

polyzen commented Apr 13, 2020

Looks like for each font found to have a license, a copy of every type of license found was added to their patched fonts dir, and not just their own license.

Also found OFL.txt and Terminus/terminus-ttf-4.40.1/COPYING to be missing with rg -l copyright src/unpatched-fonts:

@ryanoasis
Copy link
Owner

@polyzen thanks for checking my work!

hmm yeah it definitely wasn't perfect, I found that OpenDyslexic doesn't have a separate license file, so I'll make one from it's readme.

Also found OFL.txt and Terminus/terminus-ttf-4.40.1/COPYING to be missing with rg -l copyright src/unpatched-fonts

Let me tweak the script so that gets copied as well...

--

Okay I think I've got them all now.. 🤞

@polyzen
Copy link
Contributor

polyzen commented Apr 14, 2020

@polyzen thanks for checking my work!

Was rebasing my PR over master and then sorta absentmindedly went looking at the log. :p Noticed there weren't any COPYING license files being copied over, which are somewhat common. Was surprised to only find the one, then figured I'd do a search for "copyright".

hmm yeah it definitely wasn't perfect, I found that OpenDyslexic doesn't have a separate license file, so I'll make one from it's readme.

I had noticed patched-fonts/OpenDyslexic/ already had the readme files with the license in it -- think that's sufficient.

@ryanoasis
Copy link
Owner

I had noticed patched-fonts/OpenDyslexic/ already had the readme files with the license in it -- think that's sufficient.

Yeah I agree but I think that'll be hard to automate so I pulled out the license part of the readme and put it in a separate license file, so that we don't have to think about it too much or have to copy all readme files.

Noticed there weren't any COPYING license files being copied over

Hmm right, should those be? Can you point to an example? The ones that I've seen also had a separate license file.

@ryanoasis ryanoasis changed the title Question: Where are the licenses for each font? Provide license files for each patched font folder and include in future archives Apr 15, 2020
@polyzen
Copy link
Contributor

polyzen commented Apr 15, 2020

unpatched-fonts/Terminus/terminus-ttf-4.40.1/COPYING is the one I had found. There's a LICENSE.txt in there as well, but they slightly differ:

1c1
< Copyright (c) 2010 Dimitar Toshkov Zhekov,
---
> Copyright (c) 2012 Dimitar Toshkov Zhekov,
3,5c3
< 
< Copyright (c) 2011 Tilman Blumenbach,
< with Reserved Font Name "Terminus (TTF)".
---
> Copyright (c) 2013, Kim Silkebækken, Nikolay Pavlov and Carl X. Su.

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants