-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide license files for each patched font folder and include in future archives #463
Comments
My bad, turns out they are under the unpatched font directory. Would it be possible for you to automate dumping these in the patched fonts directory? |
No worries, yes!
Yes we could do that. Curious if you were just curious or you see some potential licensing issue? |
Generally licenses are required to be distributed along with what they're licensing. |
Thanks for looking out. Yeah there is a potentially major issue here.. I guess I know what I'll be working on next |
This will be fixed in the archives from now on in any future releases. Also the licenses should now be present in the patched directories as siblings to the actual font files, for example: https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/BigBlueTerminal/complete |
Looks like for each font found to have a license, a copy of every type of license found was added to their patched fonts dir, and not just their own license. Also found |
@polyzen thanks for checking my work! hmm yeah it definitely wasn't perfect, I found that OpenDyslexic doesn't have a separate license file, so I'll make one from it's readme.
Let me tweak the script so that gets copied as well... -- Okay I think I've got them all now.. 🤞 |
Was rebasing my PR over master and then sorta absentmindedly went looking at the log. :p Noticed there weren't any
I had noticed |
Yeah I agree but I think that'll be hard to automate so I pulled out the license part of the readme and put it in a separate license file, so that we don't have to think about it too much or have to copy all readme files.
Hmm right, should those be? Can you point to an example? The ones that I've seen also had a separate license file. |
|
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
🗹 Requirements
🎯 Subject of the issue
I am unable to find the license.txt/ license.md for each patched font, however, these appear to be included in a previous release
🔧 Your Setup
Anonymice Powerline Nerd Font Complete.ttf
)? Anyiterm2
,urxvt
,gnome
,konsole
)? N/A★ Optional
The text was updated successfully, but these errors were encountered: