Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font patcher in release #484

Closed
xsrvmy opened this issue Jun 1, 2020 · 6 comments
Closed

Add font patcher in release #484

xsrvmy opened this issue Jun 1, 2020 · 6 comments
Milestone

Comments

@xsrvmy
Copy link

xsrvmy commented Jun 1, 2020

Currently the releases do not contain the font patcher. The only way to download the patcher and its fonts is to manually download, or to use some obscure feature of git or svn to download the individual folder of the patcher. Can this be made into a release?

@Strahinja
Copy link

It would be great to have some kind of option to cherry-pick only parts of this repository, or a separate font-patcher-only repository (with all the necessary files to patch custom fonts). Just a simple git fetch takes ages and unnecessary disk space.

@betaboon
Copy link

betaboon commented Jul 4, 2020

i wanted that too and realy didnt feel like downloading 2GB just for the patcher.
until the maintainers found a solution for that i created a repo for that purpose: https://github.com/betaboon/nerd-fonts-patcher
it contains just the minimum required files from this repository.

@muni-corn
Copy link

Hey @ryanoasis, could we get your thoughts on this? Got a few folks in the NixOS community rooting for this ^_^

@ryanoasis
Copy link
Owner

Things are going to be changing. Patcher and it's required files are going to live in a separate repo.

Putting the patcher in the release is still an interesting idea. Releases are one of my main focuses ATM since they are a PITA and really slowing everything down. Have made progress but nothing public yet.

@ryanoasis
Copy link
Owner

Things are going to be changing. Patcher and it's required files are going to live in a separate repo.

I've for the moment done a 180º upon more consideration, I think now that having the font patcher part of the release solves most/all problems as it'll come bundled with the necessary files. Also moving to a separate repo seems like it'll only cause maintenance issues without providing much benefit. Open to more discussion: #716

for 2.2.0-RC see: https://github.com/ryanoasis/nerd-fonts/releases/download/2.2.0-RC/FontPatcher.zip

@ryanoasis ryanoasis added this to the v2.2.0 milestone Jan 10, 2022
@Finii Finii closed this as completed Aug 22, 2022
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants