nerd-font-patcher: init at 2.1.0

[ck3d]

Motivation for this change

Package font-patcher from nerd fonts.

see also #124042

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[muni-corn]

Does this have the same limitation as #124042 in that it downloads 2+ GB of tarball?

[ck3d]

Yes if fact, thanks for figuring out! I switched to the repo mentioned in ryanoasis/nerd-fonts#484 .

[betaboon]

using nerd-font-patcher in nixos was the sole reason i created that repo ;)

[SuperSandro2000]

Suggested change

	-e 's,__dir__ + "/src,"'$out'/share/${pname},'
	-e 's,__dir__ + "/src,"'$out'/share/nerd-font-patcher,'

[ck3d]

I do not see how this improves the readability nor maintainability.

[SuperSandro2000]

Substitung pname all over the place makes it harder to understand what is going on because you need to substitute the variable in your head. This is an anti pattern and for many people including me this makes it harder to know what is going on.

Also the chance that the name of the program ever changes is very slim but that we change pname for organizational purposes is heigher which would break the package.

[ck3d]

I understand your point. From my perspective, I had a different feeling while writing the code, since pname is quite long.

Do we have a coding standard, where we can define and discuss such preferences?

[SuperSandro2000]

Suggested change

	mkdir -p $out/bin $out/share/${pname}
	install -Dm755 font-patcher $out/bin/${pname}
	cp -ra src/glyphs $out/share/${pname}
	mkdir -p $out/share/nerd-font-patcher
	install -Dm755 font-patcher $out/bin/nerd-font-patcher
	cp -ra src/glyphs $out/share/nerd-font-patcher

[ck3d]

I do not see how this improves the readability nor maintainability.

[ck3d]

Thanks for the recommended changes. I updated the commit.

[mainrs]

Are there examples on how to use this properly to patch a font? Maybe having a custom hook to patch fonts would be beneficial 🤔

[muni-corn]

@mainrs I have a working example here: https://codeberg.org/harrisonthorne/iosevka-muse/src/branch/main/flake.nix#L24

Is that what you're looking for?

[mainrs]

@mainrs I have a working example here: codeberg.org/harrisonthorne/iosevka-muse/src/branch/main/flake.nix#L24

Is that what you're looking for?

Yes! Thank you very much!

[dit7ya]

@harrisonthorne Thanks for your example. I tried it with cachix but seems like it goes through the entire patching process every rebuild. Do you know any way to cache the final results?

[mainrs]

@harrisonthorne Thanks for your example. I tried it with cachix but seems like it goes through the entire patching process every rebuild. Do you know any way to cache the final results?

This depends on your inputs. I added a pinned version of nixpkgs that I specifically use for these type of derivations. nerd-font-patcher gets updated a lot and therefore you almost always have to completely patch your fonts again, even if the font itself didn't change.

By using a pinned version of nerd-font-patcher, you can kind of workaround this.

[partisani]

Sadly, it does not work and every single time anything changes the font rebuilds

EDIT: If you use the derivation described in the iosevka-muse repository, then change the src value to the src of the font (for example: src = iosevka-homemade.src;)