ProggyClean - Some broken icons

[F1LT3R]

I was excited to see ProggyClean in your font list. This is my favorite programming font. Unfortunately it seems the icon set may be incomplete? (I'm using OSX El Capitan)

Look at the tabs/status bar in this screen shot. I get the [?] icon. :(

ProggyCleanTT Nerd Font Complete Mono.ttf:

However, Sauce Code Pro does work with all the icons, so I am thinking this is not my setup, but the Proggy Font itself?

Sauce Code Pro Light Nerd Font Complete Mono.ttf

Here is my font section from my .vimrc file:

set noantialias       " Turn on/off Anti-Aliased Fonts

if has("gui_running")
  set transparency=2
  if has("gui_gtk2")
    set guifont=Inconsolata:12
  elseif has("gui_macvim")
    set guifont=Sauce\ Code\ Pro:h15
    "set guifont=ProggyCleanTT:h16
  elseif has("gui_win32")
    set guifont=Consolas:h11:cANSI
  endif
endif

[ryanoasis]

@F1LT3R Ah yes looks like they are missing.. not sure what is going on but I did confirm powerline glyphs are indeed missing. 😟

Thanks for the heads up! 👍

update: so...... apparently there was a typo which prevents the powerline symbol font from being copied at all! D'oh! This was a PR and I did not catch it (it's all good).

Here is an after the fix (right) and before the fix (left):

Here is the point of the issue:

Actually this issues seems to have been introduced in 9d3e60a#diff-3b192ccaec850d73e6540b7eddd8b50cR360

[F1LT3R]

That was quick! :)

Looking forward to updates.

Perhaps this is the wrong place to ask, but I'll try anyway: I wondered if
we can get ProggyCleanTTSZ on the list? That would be ProggyCleanTT with
slashed zeros instead of dotted zeros.

On Mon, Mar 14, 2016 at 12:39 PM, Ryan L McIntyre notifications@github.com
wrote:

@F1LT3R https://github.com/F1LT3R Ah yes looks like they are missing..
not sure what is going on but I did confirm powerline glyphs are indeed
missing. [image: 😟]

Thanks for the heads up! [image: 👍]

update: so...... apparently there was a typo which prevents the
powerline symbol font from being copied at all! D'oh! This was a PR and I
did not catch it (it's all good).

Here is an after the fix (right) and before the fix (left):

[image: selection_14_03_16_12 27 59_506x142_001]
https://cloud.githubusercontent.com/assets/8083459/13751470/bcf52242-e9e0-11e5-96c4-28bd4c9fd590.png

Here is the point of the issue:

Actually this issues seems to have been introduced in 9d3e60a
#diff-3b192ccaec850d73e6540b7eddd8b50cR360
9d3e60a#diff-3b192ccaec850d73e6540b7eddd8b50cR360

—
Reply to this email directly or view it on GitHub
#68 (comment)
.

[ryanoasis]

can get ProggyCleanTTSZ on the list

Sure 😄, just make a separate issue or I will make one soon if you'd rather.

I think I came across a bunch of ProggyClean variations and in my ignorance wasn't sure exactly what the differences were and picked only a few to patch.

[F1LT3R]

I did try checking out nerd-fonts and patching ProggyCleanTT myself changing line: 421

if args.powerline:
    copy_glyphs(sourceFont, symbolsPowerlineRange1Start, symbolsPowerlineRange1End, powerlineSymbols, symbolsPowerlineRange1Start, symbolsPowerlineRange1End)

I ran:

ontforge -script font-patcher unpatched-sample-fonts/ProggyClean/Regular/ProggyClean.ttf --fontawesome --octicons --pomicons --powerline --powerlineextra

And also with --careful..

But these did not seem to fix the issue for me :(

[F1LT3R]

What program are you using in your screenshot where you are checking that the correct glyphs are at the correct registers?

[F1LT3R]

Ah, I changed the next line also and it seems like I have glyphs! 😄

But... they seem to be a funny size. Maybe I can live with that?

[F1LT3R]

Created PR: #71

if args.powerline:
    copy_glyphs(sourceFont, symbolsPowerlineRange1Start, symbolsPowerlineRange1End, powerlineSymbols, symbolsPowerlineRange1Start, symbolsPowerlineRange1End)
    copy_glyphs(sourceFont, symbolsPowerlineRange2Start, symbolsPowerlineRange2End, powerlineSymbols, symbolsPowerlineRange2Start, symbolsPowerlineRange2End)

[ryanoasis]

What program are you using in your screenshot where you are checking that the correct glyphs are at the correct registers?

FontForge gui. Not an extensive check sorry just quickly opened the patched fonts to verify my theory.

... I have glyphs! 😄

Glad it worked for you as well! 😄 Thanks for checking it too.

But... they seem to be a funny size. Maybe I can live with that?

This something a bit tricky I need to improve and work on and there are similar issues currently open related to glyph sizing and/or positioning issues.

PR

Great thanks, I'll get it in to the next release 👍

[github-actions]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.