Ligatures broken #976
Comments
Finii
added a commit
that referenced
this issue
Oct 20, 2022
[why] Keeping the ligature removal tables up to date with source font updates is quite a maintenance burden. Usually if a terminal supports ligatures at all it has an option to disable them. Present ligatures do not prevent monospaced fonts and monospaced detection. It was only present in v2.0.0, and the code has been broken with v2.1.0. [note] Updated example ligature removal table to the one for Iosevka. Left stubs in relevant code passages to facilitate finding this commit. Fixes: #976 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
that referenced
this issue
Oct 20, 2022
[why] Keeping the ligature removal tables up to date with source font updates is quite a maintenance burden. Usually if a terminal supports ligatures at all it has an option to disable them. Present ligatures do not prevent monospaced fonts and monospaced detection. It was only present in v2.0.0, and the code has been broken with v2.1.0. [note] Updated example ligature removal table to the one for Iosevka. Left stubs in relevant code passages to facilitate finding this commit. Fixes: #976 Fixes: #975 Fixes: #973 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
that referenced
this issue
Oct 20, 2022
[why] Keeping the ligature removal tables up to date with source font updates is quite a maintenance burden. Usually if a terminal supports ligatures at all it has an option to disable them. Present ligatures do not prevent monospaced fonts and monospaced detection. It was only present in v2.0.0, and the code has been broken with v2.1.0. [note] Updated example ligature removal table to the one for Iosevka. Left stubs in relevant code passages to facilitate finding this commit. Fixes: #976 Fixes: #975 Fixes: #973 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this issue
Nov 24, 2023
[why] Keeping the ligature removal tables up to date with source font updates is quite a maintenance burden. Usually if a terminal supports ligatures at all it has an option to disable them. Present ligatures do not prevent monospaced fonts and monospaced detection. It was only present in v2.0.0, and the code has been broken with v2.1.0. [note] Updated example ligature removal table to the one for Iosevka. Left stubs in relevant code passages to facilitate finding this commit. Fixes: ryanoasis#976 Fixes: ryanoasis#975 Fixes: ryanoasis#973 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Nerd Font used to have a 'ligature removal' feature for the
Nerd Font Monofonts.This seems to be broken with recent fonts (i.e.
v2.2.2seems ok whileHEADis broken).See also
The reason is the recent fix of the ligature removal code (i.e. 5d218b1).
History data:
v2.0.0) 9917e2dv2.1.0) 0a480bbv2.3.0-RC) 5d218b1Fonts with ligature table data:
The tables have been added with a2f5620 and never been updated (which would generally be needed if the source font is updated) (except Hasklug 12cd703).
Affected (very quick check) is only FiraCode and Hasklig.
Updated after introduction of the ligature removal are
Of the three Iosevka's ligature removal seems to have survived the updates, but maybe not.
The text was updated successfully, but these errors were encountered: