Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hasklig #103

Merged
merged 1 commit into from
Dec 16, 2016
Merged

Add Hasklig #103

merged 1 commit into from
Dec 16, 2016

Conversation

jrolfs
Copy link
Collaborator

@jrolfs jrolfs commented Sep 19, 2016

Perhaps there are more variants than we care about?

Chug-a-lug:
patching

@ryanoasis
Copy link
Owner

Good question, it's both a positive of this whole project but also can be a negative 😛

Sorry I haven't followed up on this yet until now.

@jrolfs
Copy link
Collaborator Author

jrolfs commented Oct 10, 2016

No worries, yeah it's definitely both a plus and minus. Git has gotten better with binary files but dumping a bunch more in can definitely bloat the repo...

The problem here is that the source font provides so many variants which could be useful, however we could limit the variants included to something similar to another font that provides variants (like Source Code Pro from which this ligature font is derived).

@ryanoasis
Copy link
Owner

Yeah...

Over 5,700 unique combinations/variations of patched fonts

Is more of a bragging point than something actually feasible/useful in real life 😉

My thinking on the whole massive amounts of variations issue is that should be addressed but maybe in a few versions (probably 1.0.0) and for now I'd like to move forward with enhancements and easy bugs (to avoid getting stuck on the hard ones). Anyway I am going to put more time into this project again and start preparing for v0.9.0. I'll probably create the branch and merge this in tomorrow 😄

Related:

@ryanoasis
Copy link
Owner

whoops I did something wrong in the feature branch flow. the changes for this and commits are there but it's just not marked as 'merged'

@ryanoasis ryanoasis merged commit a89b3db into ryanoasis:master Dec 16, 2016
ryanoasis added a commit that referenced this pull request Dec 16, 2016
ryanoasis added a commit that referenced this pull request Jan 15, 2017
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants