font-patcher: Drop box-drawing from SymbolsOnly #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] The Box Drawing glyphs need to be carefully scaled. This can not be done if the glyphs are pulled in via font-fallback I guess. As people may have the fontconfig set up in a way to prefer the Symbols Only font these glyphs could overrule other box drawing glyphs that might fit better. I'm not really sure about this one, but the glyphs look rather bad anyhow, because they end up in the 1:1 ascpect ratio cell of the Symbols Only font. [how] Just turn the set off if we patch the Symbols Only font. Need to swap around two subroutine calls for that; first detect if we are patching the Symbols Only font (through the font metrics) and then set the patch sets up. Fixes: #1210 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
The Box Drawing glyphs need to be carefully scaled. This can not be done if the glyphs are pulled in via font-fallback I guess.
As people may have the fontconfig set up in a way to prefer the Symbols Only font these glyphs could overrule other box drawing glyphs that might fit better.
I'm not really sure about this one, but the glyphs look rather bad anyhow, because they end up in the 1:1 ascpect ratio cell of the Symbols Only font.
[how]
Just turn the set off if we patch the Symbols Only font. Need to swap around two subroutine calls for that; first detect if we are patching the Symbols Only font (through the font metrics) and then set the patch sets up.
Fixes: #1210
Requirements / Checklist
What does this Pull Request (PR) do?
Drop the box drawing glyphs from the Symbols Only font(s).
They have been introduced with 3.0.0
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)