Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive-fonts: Create tar.xz packs #1235

Merged
merged 3 commits into from
Jun 2, 2023
Merged

archive-fonts: Create tar.xz packs #1235

merged 3 commits into from
Jun 2, 2023

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented May 12, 2023

See #1233

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Fixes: #1233

Screenshots (if appropriate or helpful)

No functional change except working in sorted order.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii force-pushed the feature/pack-xz branch 2 times, most recently from ccfcb21 to dcac355 Compare June 2, 2023 10:39
@Finii Finii marked this pull request as ready for review June 2, 2023 10:40
@Finii
Copy link
Collaborator Author

Finii commented Jun 2, 2023

This started as a test but the feedback was overwhelmingly good and ppl seem to expect that this stays 😬

Finii added 2 commits June 2, 2023 13:08
[why]
Scripts should run regardless of current working directory.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
See #1233

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii merged commit f6f8099 into master Jun 2, 2023
@Finii Finii deleted the feature/pack-xz branch June 2, 2023 11:10
@Finii
Copy link
Collaborator Author

Finii commented Jun 2, 2023

@allcontributors please add @N-R-K for ideas

@allcontributors
Copy link
Contributor

@Finii

Could not find the user N-R#/#K on github.

@Finii
Copy link
Collaborator Author

Finii commented Jun 2, 2023

@allcontributors please add N-R-K for ideas

@allcontributors
Copy link
Contributor

@Finii

Could not find the user N-R#/#K on github.

@N-R-K
Copy link

N-R-K commented Jun 2, 2023

Could not find the user N-R#/#K on github.

image

Finii added a commit that referenced this pull request Jun 2, 2023
Obviously the bot is not working with a name with two dashes, see
PR #1235 for my attempts :-/

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator Author

Finii commented Jun 2, 2023

Am I blind? Why is the link on your avatar working but clicking on your name on the contributors page is not?!?

image

image

@N-R-K
Copy link

N-R-K commented Jun 2, 2023

image

Missing the colon 🤔

@Finii
Copy link
Collaborator Author

Finii commented Jun 2, 2023

image

colons ... 😬

@Finii
Copy link
Collaborator Author

Finii commented Jun 2, 2023

Could not find the user N-R#/#K on github.

image

Related:

😬

LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Obviously the bot is not working with a name with two dashes, see
PR ryanoasis#1235 for my attempts :-/

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide alternate, better compressed tarballs
2 participants